Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data eviction implementation #221

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Improve data eviction implementation #221

merged 1 commit into from
Apr 17, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Apr 17, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #221 (010e278) into dev (88bc249) will increase coverage by 0.17%.
The diff coverage is 91.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #221      +/-   ##
==========================================
+ Coverage   92.56%   92.73%   +0.17%     
==========================================
  Files          48       52       +4     
  Lines        1546     1584      +38     
==========================================
+ Hits         1431     1469      +38     
  Misses        115      115              
Impacted Files Coverage Δ
gptcache/manager/object_data/manager.py 85.71% <50.00%> (ø)
gptcache/manager/eviction/base.py 76.92% <76.92%> (ø)
gptcache/manager/eviction/memory_cache.py 90.90% <90.90%> (ø)
gptcache/manager/data_manager.py 88.52% <92.30%> (-0.28%) ⬇️
gptcache/manager/eviction/__init__.py 100.00% <100.00%> (ø)
gptcache/manager/eviction/manager.py 100.00% <100.00%> (ø)
gptcache/manager/eviction_manager.py 96.55% <100.00%> (ø)
gptcache/manager/scalar_data/base.py 85.45% <100.00%> (+2.64%) ⬆️
gptcache/manager/scalar_data/manager.py 100.00% <100.00%> (ø)
gptcache/manager/scalar_data/sql_storage.py 95.83% <100.00%> (-0.47%) ⬇️
... and 2 more

Signed-off-by: SimFG <bang.fu@zilliz.com>
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 17, 2023
@SimFG SimFG merged commit 6e07e29 into zilliztech:dev Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants