Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fail to save the data to cache #224

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix to fail to save the data to cache #224

merged 1 commit into from
Apr 17, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Apr 17, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: SimFG <bang.fu@zilliz.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #224 (64759f3) into dev (4dddcf0) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 64759f3 differs from pull request most recent head 33012ce. Consider uploading reports for the commit 33012ce to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #224      +/-   ##
==========================================
- Coverage   92.73%   92.67%   -0.07%     
==========================================
  Files          52       52              
  Lines        1584     1584              
==========================================
- Hits         1469     1468       -1     
- Misses        115      116       +1     
Impacted Files Coverage Δ
gptcache/adapter/openai.py 92.06% <100.00%> (+0.79%) ⬆️

... and 1 file with indirect coverage changes

@SimFG SimFG merged commit eb8ac29 into zilliztech:dev Apr 17, 2023
@mergify mergify bot added the ci-passed label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants