Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#486: provide redis_connection for creating all Object Models #487

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

a9raag
Copy link
Contributor

@a9raag a9raag commented Jul 14, 2023

Bug fix for the issue

Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #487 (fd747f3) into dev (42ac9b9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #487      +/-   ##
==========================================
+ Coverage   94.06%   94.07%   +0.01%     
==========================================
  Files          93       93              
  Lines        3810     3817       +7     
==========================================
+ Hits         3584     3591       +7     
  Misses        226      226              
Impacted Files Coverage Δ
gptcache/manager/scalar_data/redis_storage.py 97.63% <100.00%> (+0.10%) ⬆️

@mergify mergify bot added the ci-passed label Jul 14, 2023
@SimFG
Copy link
Collaborator

SimFG commented Jul 14, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a9raag, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a5fc129 into zilliztech:dev Jul 14, 2023
8 checks passed
@a9raag a9raag deleted the bugfix/486 branch September 14, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants