Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle openai change of api base for just embeddings #495

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

keeganmccallum
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keeganmccallum
To complete the pull request process, please assign simfg after the PR has been reviewed.
You can assign the PR to them by writing /assign @simfg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from cxie and SimFG July 24, 2023 19:28
@sre-ci-robot
Copy link
Collaborator

Welcome @keeganmccallum! It looks like this is your first PR to zilliztech/GPTCache 🎉

@SimFG
Copy link
Collaborator

SimFG commented Jul 25, 2023

@keeganmccallum thank your pr, please make the dev as the target branch

@SimFG SimFG changed the base branch from main to dev July 25, 2023 03:42
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #495 (071408c) into dev (a3328f2) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #495      +/-   ##
==========================================
- Coverage   94.20%   94.18%   -0.02%     
==========================================
  Files          94       94              
  Lines        3898     3903       +5     
==========================================
+ Hits         3672     3676       +4     
- Misses        226      227       +1     
Files Changed Coverage Δ
gptcache/embedding/openai.py 94.11% <85.71%> (-2.44%) ⬇️

@SimFG SimFG merged commit 03a0597 into zilliztech:dev Jul 25, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants