Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back un-necessary faiss change #81

Closed
cydrain opened this issue Sep 13, 2023 · 5 comments
Closed

Roll back un-necessary faiss change #81

cydrain opened this issue Sep 13, 2023 · 5 comments
Assignees

Comments

@cydrain
Copy link
Collaborator

cydrain commented Sep 13, 2023

No description provided.

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 13, 2023

/assign

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 13, 2023

related PR: milvus-io/milvus#3015

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 15, 2023

Screenshot from 2023-09-15 10-45-14

In Milvus 1.x, we did some enhancement in flat search.
From above code piece, we can see that it uses a complicated logic to decide to do parallel on nx or ny.
But in Milvus 2.x, knowhere uses folly to do parallel:
Screenshot from 2023-09-15 11-00-28

It makes 'nx' is always equal to 1, and omp_get_max_threads() always returns 1.
So there is no difference between do parallel on nx or ny.

So we can remove these APIs:

  • exhaustive_L2sqr_IP_seq()
  • exhaustive_L2sqr_IP_seq_on_nx()
  • exhaustive_L2sqr_IP_seq_on_ny()

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 15, 2023

/close

@sre-ci-robot
Copy link
Collaborator

@cydrain: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants