Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new param 'empty_result_nbucket' for IVF range search #455

Merged

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Mar 12, 2024

This param is used for BIN_IVF_FLAT, IVF_FLAT, IVF_FLAT_CC, IVF_SQ8 and IVF_PQ
Issue: #454

Copy link

mergify bot commented Mar 12, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
@cydrain cydrain force-pushed the caiyd_add_more_params_for_range_search branch from f534bcd to 56c1d89 Compare March 14, 2024 08:17
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Mar 14, 2024
@sre-ci-robot sre-ci-robot merged commit 3b2fafc into zilliztech:main Mar 14, 2024
9 checks passed
@cydrain cydrain deleted the caiyd_add_more_params_for_range_search branch March 14, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants