Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging more changes from the faiss baseline #510

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Apr 18, 2024

Most of the changes are nits and tiny tweaks or code cleanups. There should be nothing groundbreaking.
/kind improvement

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Copy link

mergify bot commented Apr 18, 2024

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (3c46f4c) to head (15fbd12).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #510       +/-   ##
=========================================
+ Coverage      0   72.36%   +72.36%     
=========================================
  Files         0       63       +63     
  Lines         0     4291     +4291     
=========================================
+ Hits          0     3105     +3105     
- Misses        0     1186     +1186     

see 63 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 18, 2024
@liliu-z
Copy link
Collaborator

liliu-z commented Apr 23, 2024

/lgtm

@cydrain
Copy link
Collaborator

cydrain commented Apr 23, 2024

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Collaborator

liliu-z commented Apr 23, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 68ac152 into zilliztech:main Apr 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants