Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports natsmq #4

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Supports natsmq #4

merged 1 commit into from
Aug 16, 2023

Conversation

haorenfsa
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 80.32% and project coverage change: +0.03% 🎉

Comparison is base (8c06a63) 80.05% compared to head (c3cbe24) 80.08%.

❗ Current head c3cbe24 differs from pull request most recent head 2e122d9. Consider uploading reports for the commit 2e122d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   80.05%   80.08%   +0.03%     
==========================================
  Files          46       47       +1     
  Lines        4707     4750      +43     
==========================================
+ Hits         3768     3804      +36     
- Misses        795      799       +4     
- Partials      144      147       +3     
Files Changed Coverage Δ
apis/milvus.io/v1beta1/persistence_types.go 0.00% <0.00%> (ø)
pkg/controllers/dependencies.go 82.45% <0.00%> (ø)
pkg/controllers/pvc.go 95.23% <50.00%> (-4.77%) ⬇️
pkg/controllers/configmaps.go 64.42% <83.33%> (+1.53%) ⬆️
apis/milvus.io/v1beta1/milvus_webhook.go 86.33% <90.00%> (-0.19%) ⬇️
apis/milvus.io/v1beta1/milvus_types.go 75.65% <100.00%> (+1.57%) ⬆️
pkg/controllers/deployment_updater.go 87.67% <100.00%> (-0.17%) ⬇️
pkg/controllers/status_cluster.go 87.24% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa force-pushed the natsmq branch 2 times, most recently from 6ff1b63 to fb414ce Compare August 15, 2023 11:03
@haorenfsa haorenfsa enabled auto-merge (rebase) August 15, 2023 11:04
@haorenfsa haorenfsa force-pushed the natsmq branch 4 times, most recently from 22d6679 to 1871ee2 Compare August 16, 2023 08:43
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@mintcckey
Copy link
Contributor

/lgtm

@haorenfsa haorenfsa added approved lgtm looks good to merge labels Aug 16, 2023
@sre-ci-robot sre-ci-robot merged commit 1c1aa15 into zilliztech:main Aug 16, 2023
12 checks passed
@haorenfsa haorenfsa deleted the natsmq branch August 17, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm looks good to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants