add max version for pygit2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently (12Mar2020), most Mac OS X users who do a `brew install libgit2` will get version `0.28.x` yet when they then do a `pip install pygit2` they will get `1.1.x`. As per the `pygit2` [docs](https://www.pygit2.org/install.html#version-numbers), these are incompatible. Now, this isn't a flaw with battenberg itself, but unless you specifically want people to build `libgit 1.x` and then install the corresponding version, it may increase adoption and improve user experience to just put an upper bound on the pygit version to prevent 1.x from getting installed and then complaining about an old libgit: ``` src/types.h:36:2: error: You need a compatible libgit2 version (0.99.x or 1.0.x) #error You need a compatible libgit2 version (0.99.x or 1.0.x) ```
alexlatchford
approved these changes
Mar 12, 2020
|
i don't have write access so merge as you like! (no urgent need from me at the moment). Thanks alex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (12Mar2020), most Mac OS X users who do a
brew install libgit2will get version0.28.xyet when they then do apip install pygit2they will get1.1.x. As per thepygit2docs, these are incompatible.Now, this isn't a flaw with
battenbergitself, because your docs clearly specify these two libraries as dependencies. But unless you specifically want people to buildlibgit 1.xfrom source and then install the correspondingpygit2version, it may increase adoption and improve user experience to just put an upper bound on the pygit version to prevent 1.x from getting installed and then complaining about an old libgit: