Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top level dir #15

Merged
merged 5 commits into from May 19, 2020
Merged

Conversation

kevinj-z
Copy link

  • When the cookiecutter project template directory name matches a
    sub-directory name, battenberg will fail to install or upgrade to a
    collision in shutil.move.
  • Rather than moving the project files up a directory, use a separate
    temporary directory as a staging ground for the cookiecutter output.
    Then move the desired contents into the temporary worktree.

- When the cookiecutter project template directory name matches a
sub-directory name, battenberg will fail to install or upgrade to a
collision in shutil.move.
- Rather than moving the project files up a directory, use a separate
temporary directory as a staging ground for the cookiecutter output.
Then move the desired contents into the temporary worktree.
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #15 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   95.89%   96.27%   +0.38%     
==========================================
  Files           6        6              
  Lines         219      215       -4     
==========================================
- Hits          210      207       -3     
+ Misses          9        8       -1     
Impacted Files Coverage Δ
battenberg/cli.py 91.11% <100.00%> (ø)
battenberg/core.py 96.70% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7424c...995c083. Read the comment docs.

@alexlatchford alexlatchford self-requested a review May 19, 2020 20:44
@alexlatchford
Copy link
Collaborator

Would you mind updating the HISTORY.md file with the details of the change, guessing this fix is backwards compatible so just a patch release version bump should be fine.

@kevinj-z
Copy link
Author

bumped to 0.2.3 in HISTORY.md. from all of my testing, the change is backwards compatible.

HISTORY.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexlatchford alexlatchford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just tested it out on one of our projects and didn't break! Thanks for the contribution. Ping me on Slack when you've merged this and I can git tag and publish a new version for you :)

@alexlatchford alexlatchford merged commit 070b5dd into zillow:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants