New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top level dir #15
Conversation
- When the cookiecutter project template directory name matches a sub-directory name, battenberg will fail to install or upgrade to a collision in shutil.move. - Rather than moving the project files up a directory, use a separate temporary directory as a staging ground for the cookiecutter output. Then move the desired contents into the temporary worktree.
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 95.89% 96.27% +0.38%
==========================================
Files 6 6
Lines 219 215 -4
==========================================
- Hits 210 207 -3
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
Would you mind updating the |
bumped to 0.2.3 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just tested it out on one of our projects and didn't break! Thanks for the contribution. Ping me on Slack when you've merged this and I can git tag
and publish a new version for you :)
sub-directory name, battenberg will fail to install or upgrade to a
collision in shutil.move.
temporary directory as a staging ground for the cookiecutter output.
Then move the desired contents into the temporary worktree.