fix(errors): Move no-restricted-exports to es6 rules, enable

zillow · Sep 29, 2020 · b9845de · b9845de
1 parent abb2346
commit b9845de
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/packages/eslint-config-zillow-base/rules/errors.js b/packages/eslint-config-zillow-base/rules/errors.js
@@ -112,9 +112,6 @@ module.exports = {
     // disallow multiple spaces in a regular expression literal
     'no-regex-spaces': 'error',
 
-    // https://eslint.org/docs/rules/no-restricted-exports
-    'no-restricted-exports': 'off',
-
     // https://eslint.org/docs/rules/no-setter-return
     'no-setter-return': 'error',
 

diff --git a/packages/eslint-config-zillow-base/rules/es6.js b/packages/eslint-config-zillow-base/rules/es6.js
@@ -63,6 +63,17 @@ module.exports = {
     // https://eslint.org/docs/rules/no-new-symbol
     'no-new-symbol': 'error',
 
+    // Disallow specified names in exports
+    // https://eslint.org/docs/rules/no-restricted-exports
+    'no-restricted-exports': ['error', {
+      restrictedNamedExports: [
+        // use `export default` to provide a default export
+        'default',
+        // this will cause tons of confusion when your module is dynamically `import()`ed
+        'then',
+      ],
+    }],
+
     // disallow specific imports
     // https://eslint.org/docs/rules/no-restricted-imports
     'no-restricted-imports': ['off', {

diff --git a/packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap b/packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap
@@ -1172,7 +1172,13 @@ Object {
       "error",
     ],
     "no-restricted-exports": Array [
-      "off",
+      "error",
+      Object {
+        "restrictedNamedExports": Array [
+          "default",
+          "then",
+        ],
+      },
     ],
     "no-restricted-globals": Array [
       "error",