Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly data exploration failure #112

Closed
sayanchk opened this issue Sep 7, 2022 · 1 comment
Closed

Weekly data exploration failure #112

sayanchk opened this issue Sep 7, 2022 · 1 comment

Comments

@sayanchk
Copy link
Collaborator

sayanchk commented Sep 7, 2022

Reference:

https://github.com/papaemman/luminaire_demo

TL:DR; Data Exploration module doesn't work for time series with frequency 'W' because of a missing variable (tc_window_length). Any idea why is this happening?
sayanchk added a commit to sayanchk/luminaire that referenced this issue Sep 7, 2022
@sayanchk
bug zillow#112: window size identification fixed for trend change det…
4385582 
…ection
papaemman added a commit to papaemman/luminaire that referenced this issue Sep 15, 2022
@papaemman
bug zillow#112: window size identification fixed
c6f1a63 
for trend change detection
@papaemman papaemman mentioned this issue Sep 15, 2022
Merged
papaemman added a commit to papaemman/luminaire that referenced this issue Sep 15, 2022
@papaemman
Merge pull request #1 from papaemman/bug/weekly-exploration-failure
c9008d5 
bug zillow#112: window size identification fixed for trend change detection
shahsmit14 added a commit that referenced this issue Sep 29, 2022
@shahsmit14
Merge pull request #114 from papaemman/bug/weekly-exploration-failure
0af6a34 
bug #112: support for weekly frequency
@sayanchk
Copy link
Collaborator Author

sayanchk commented Oct 23, 2022 •
edited
Loading

Fixed under v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sayanchk