Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 1 of 2] AIP-5426: Revert prior KFP CLI fixes #14

Merged
merged 3 commits into from
Jan 11, 2022

Conversation

alexlatchford
Copy link
Collaborator

@alexlatchford alexlatchford commented Jan 5, 2022

Description of your changes:

This reverts the changes from:

These changes originally moved the kfp-cli fixes from aip-kfp-sdk into zillow-kfp. I'm reverting these in favor of pulling in the upstream changes from zillow/pipelines we contributed in the Part 2 PR. The ones we actually want are:

To achieve this I've run git pull upstream sdk/release-1.8 to pull in the sdk/release-1.8 branch, from which they most recently released kfp==1.8.10 (see here), this includes all these changes.

In short, the version of the code we have in feature/zg differs a little from the master of the upstream zillow/pipelines branch. This 2 part PR group tries to align us totally with the open source!

@alexlatchford alexlatchford merged commit a73cc36 into feature/zg Jan 11, 2022
@alexlatchford alexlatchford deleted the alexla/AIP-5426-pt1 branch January 11, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants