Fix page links with whitespace

Fix page links with preceding or trailing whitespace Fixes #2256
zim-desktop-wiki · May 30, 2023 · f4a33c7 · f4a33c7
1 parent 04b93c6
commit f4a33c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/zim/gui/pageview/__init__.py b/zim/gui/pageview/__init__.py
@@ -1241,7 +1241,8 @@ def get_link_data(self, iter, raw=False):
 				else:
 					# Copy text content as href
 					start, end = self.get_tag_bounds(iter, tag)
-					link['href'] = start.get_text(end)
+					link['href'] = start.get_text(end).strip()
+						# assume starting or trailing whitespace is an editing artefact
 			return link
 		else:
 			return None

diff --git a/zim/notebook/page.py b/zim/notebook/page.py
@@ -360,6 +360,8 @@ def new_from_wiki_link(klass, href: str) -> 'Href':
 		@note: This method HRef class assumes the logic of our wiki links.
 		For other formats, a separate constructor may be needed.
 		'''
+		href = href.strip()
+
 		if href.startswith(':'):
 			rel = HREF_REL_ABSOLUTE
 		elif href.startswith('+'):