distraction free editing plugin: remove all colors of the window chrome #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the window chrome
|
Thanks for the patch! Would it make sense to add a separate preference
for the background color to allow different background colors for the text
and the box if a user prefers that ?
…-- Jaap
On Wed, Apr 15, 2020 at 9:23 PM rscmbbng ***@***.***> wrote:
The box colors are set to the same value as the background color for true
distraction free editing.
Regular view:
<https://camo.githubusercontent.com/4fc76aa245fd09e7b6bb4f62c8c625776568657a/68747470733a2f2f692e696d6775722e636f6d2f536453673465312e706e67>
Distraction free before:
<https://camo.githubusercontent.com/8bfc3774cde1de53beeac959ea79b85cff6e7bfd/68747470733a2f2f692e696d6775722e636f6d2f3874593137364c2e706e67>
Distraction free after patch:
<https://camo.githubusercontent.com/7c78e5bb3830af4564c7e1647bf827d2a1a50219/68747470733a2f2f692e696d6775722e636f6d2f533536383131532e706e67>
------------------------------
You can view, comment on, or merge this pull request online at:
#1051
Commit Summary
- make the plugin truly distraction free by removing all the colors of
the window chrome
File Changes
- *M* zim/plugins/distractionfree.py
<https://github.com/zim-desktop-wiki/zim-desktop-wiki/pull/1051/files#diff-3e3c767357e81e538a60909fb2b9c651>
(9)
Patch Links:
- https://github.com/zim-desktop-wiki/zim-desktop-wiki/pull/1051.patch
- https://github.com/zim-desktop-wiki/zim-desktop-wiki/pull/1051.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1051>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJQYHR55ASSJGGRRYRQSSDRMYCT7ANCNFSM4MI2ZHWQ>
.
|
|
Personally I don't think so. Do you prefer Zim to have more toggles/customization or more 'sane defaults?' An option could be easily added, but I think most distraction-free writing modes have a single background color and that is more in the line of expectations. Another thing is: given a single background+box color, the option 'Border width' essentially becomes a top/bottom margin height option. |
|
Merged in develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The box colors are set to the same value as the background color for true distraction free editing.
Regular view:
Distraction free before:
Distraction free after patch:
