Sort header keys when making message

zimeon · Dec 5, 2015 · b502467 · b502467
1 parent 5a96672
commit b502467
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/iiif/error.py b/iiif/error.py
@@ -107,15 +107,16 @@ def as_txt(self):
             s += "parameter=%s\n" % self.parameter
         if (self.code):
             s += "code=%d\n\n" % self.code
-        for header in self.headers:
+        for header in sorted(self.headers):
             s += "header %s=%s\n" % (header,self.headers[header])
         return s
 
     def __str__(self):
         """Default human readable version of IIIF error.
 
         Intention is that image server implementations will use
-        image_server_response(api_version) instead
+        image_server_response(api_version) instead. Does not include
+        header values in output
         """
         s = self.text if (self.text) else 'UNKNOWN_ERROR'
         if (self.parameter):

diff --git a/tests/test_error.py b/tests/test_error.py
@@ -30,7 +30,7 @@ def test03_txt(self):
         e = IIIFError()
         msg = 'IIIF Image Server Error\n\nself.text\n\nparameter=unknown\ncode=500\n\n'
         self.assertEqual( e.as_txt(), msg )
-        e = IIIFError(headers={'a':'b','cc':'dd'})
+        e = IIIFError(headers={'cc':'dd','a':'b'})
         self.assertEqual( e.as_txt(), msg + 'header a=b\nheader cc=dd\n')
 
     def test04_image_server_response(self):