Adding scheme to URL to support https in info.json #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #36 (comment) |
zimeon
requested changes
Mar 8, 2021
iiif/flask_utils.py
Outdated
| uri = "http://" + host | ||
| if (port != 80): | ||
| uri = scheme + "://" + host | ||
| if port != 80 and port != 443: |
There was a problem hiding this comment.
I think this this should really be:
if not ((port == 80 and scheme == 'http') or (port == 443 and scheme == 'https')):
There was a problem hiding this comment.
Thanks Simeon, I've made that change.
zimeon
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was raised in the cookbook meetings and is starting to cause mixed content errors with Mirador. The IIIF reference implementation is hosted over https but the info.json points to http. See the following example:
https://iiif.io/api/image/3.0/example/reference/918ecd18c2592080851777620de9bcb5-gottingen/info.json
This pull requests adds a
schemeparameter to the config.