Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for non-unique logical paths #39

Closed
zimeon opened this issue Apr 15, 2021 · 3 comments
Closed

Add check for non-unique logical paths #39

zimeon opened this issue Apr 15, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@zimeon
Copy link
Owner

zimeon commented Apr 15, 2021

See OCFL/fixtures#65 which currently gets incorrectly reported as valid

@zimeon zimeon added the bug Something isn't working label Apr 15, 2021
@zimeon
Copy link
Owner Author

zimeon commented Apr 22, 2021

In E095_non_unique_logical_paths:

  "versions": {
    "v1": {
      "created": "2021-03-31T10:21:21.740101149-05:00",
      "state": {
        "07e41ccb166d21a5327d5a2ae1bb48192b8470e1357266c9d119c294cb1e95978569472c9de64fb6d93cbd4dd0aed0bf1e7c47fd1920de17b038a08a85eb4fa1": [
          "file-1.txt"
        ],
        "9fef2458ee1a9277925614272adfe60872f4c1bf02eecce7276166957d1ab30f65cf5c8065a294bf1b13e3c3589ba936a3b5db911572e30dfcb200ef71ad33d5": [
          "file-1.txt"
        ],
        "b3b26d26c9d8cfbb884b50e798f93ac6bef275a018547b1560af3e6d38f2723785731d3ca6338682fa7ac9acb506b3c594a125ce9d3d60cd14498304cc864cf2": [
          "file-3.txt", "file-4.txt", "file-3.txt"
        ]
      },

@zimeon
Copy link
Owner Author

zimeon commented Apr 22, 2021

(py38) simeon@RottenApple ocfl-py> ./ocfl-validate.py fixtures/1.0/bad-objects/E095_non_unique_logical_paths
[E095a] OCFL Object root inventory version v1 state has logical path file-1.txt used more than once. (see https://ocfl.io/1.0/spec/#E095)
[E095a] OCFL Object root inventory version v1 state has logical path file-3.txt used more than once. (see https://ocfl.io/1.0/spec/#E095)
INFO:ocfl.object:OCFL object at fixtures/1.0/bad-objects/E095_non_unique_logical_paths is INVALID

@zimeon
Copy link
Owner Author

zimeon commented Apr 26, 2021

Fixed in 1.2.2

@zimeon zimeon closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant