Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in validator.py that produced imprecise output message #45

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

awoods
Copy link
Contributor

@awoods awoods commented Apr 17, 2021

Prior to this change, running the validator on OCFL/fixtures#66 produced:

[E093] OCFL Object root inventory fixity block for digest algorithm ??? has digest..

After this change, the output is now:

[E093] OCFL Object root inventory fixity block for digest algorithm md5 has digest..

Prior to this change, running the validator on OCFL/fixtures#66 produced:
```
[E093] OCFL Object root inventory fixity block for digest algorithm ??? has digest..
```

After this change, the output is now:
```
[E093] OCFL Object root inventory fixity block for digest algorithm md5 has digest..
```
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.875% when pulling b5632d4 on awoods:fixity-check-typo into 2f72087 on zimeon:main.

@awoods
Copy link
Contributor Author

awoods commented Apr 18, 2021

Also resolves: #38

@zimeon zimeon changed the base branch from main to develop April 18, 2021 15:37
@zimeon zimeon merged commit e6e6fdc into zimeon:develop Apr 18, 2021
@zimeon
Copy link
Owner

zimeon commented Apr 18, 2021

Fixed in develop:

(py38) simeon@RottenApple ocfl-py> ./ocfl-validate.py fixtures/1.0/bad-objects/E093_fixity_digest_mismatch/
[E093] OCFL Object root inventory fixity block for digest algorithm ??? has digest 9eacfb9289073dd9c9a8c4cdf820ac71 for file v1/content/test.txt which doesn't match calculated digest eb1a3227cdc3fedbaec2fe38bf6c044a for that file (see https://ocfl.io/1.0/spec/#E093)
INFO:ocfl.object:OCFL object at fixtures/1.0/bad-objects/E093_fixity_digest_mismatch/ is INVALID
(py38) simeon@RottenApple ocfl-py> git pull
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 8 (delta 3), reused 4 (delta 3), pack-reused 0
Unpacking objects: 100% (8/8), done.
From github.com:zimeon/ocfl-py
   a7e236f..e6e6fdc  develop    -> origin/develop
Updating a7e236f..e6e6fdc
Fast-forward
 ocfl/validator.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(py38) simeon@RottenApple ocfl-py> ./ocfl-validate.py fixtures/1.0/bad-objects/E093_fixity_digest_mismatch/
[E093] OCFL Object root inventory fixity block for digest algorithm md5 has digest 9eacfb9289073dd9c9a8c4cdf820ac71 for file v1/content/test.txt which doesn't match calculated digest eb1a3227cdc3fedbaec2fe38bf6c044a for that file (see https://ocfl.io/1.0/spec/#E093)
INFO:ocfl.object:OCFL object at fixtures/1.0/bad-objects/E093_fixity_digest_mismatch/ is INVALID

@zimeon
Copy link
Owner

zimeon commented Apr 18, 2021

Thanks @awoods !

@awoods awoods deleted the fixity-check-typo branch April 18, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants