Always type-check the whole package for one file #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to type-check the whole package, or we miss something defined in another file of the same package. Unfortunately it makes sense to use go/loader which is quite slower than the pure go/types solution. However, this gets also rid of some false type-checking cases. Fixes #47
zimmski
changed the title
Altough this gets rid of some compile errors, it converts one duplicate of the example folder to a pass mutation.
zimmski
force-pushed
the
47-typecheck-whole-package-for-one-file
branch
from
f85323e
to
33d4a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.