🌸 DesignLibrary
#1187
Labels
✨ feature
Reduces Client's Burden or Grants them Benefits
🛠️ infrastructure
ci, build, deploy, networking, etc.
🌸 Polish
Improves the UX!
🌱 Ready for Dev
Stuff we are able to move forward on
🥔 Satisfices
It's good enough to use, but not particularly great
Comments
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
- #1187 This is an intermediary step before we look into `LookBook` or similar, but it: 1. Makes it possible to define component previews in `spec/components/previews` 2. Creates a basic layout for showing Components 3. Adds a `CardComponentPreview` 4. Sprouts an `ApplicationComponent` which we can start to massage into playing well with tailwind's class syntax
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
- #1187 This is an intermediary step before we look into `LookBook` or similar, but it: 1. Makes it possible to define component previews in `spec/components/previews` 2. Creates a basic layout for showing Components 3. Adds a `CardComponentPreview` 4. Sprouts an `ApplicationComponent` which we can start to massage into playing well with tailwind's class syntax
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
- #1187 This is an intermediary step before we look into `LookBook` or similar, but it: 1. Makes it possible to define component previews in `spec/components/previews` 2. Creates a basic layout for showing Components 3. Adds a `CardComponentPreview` 4. Sprouts an `ApplicationComponent` which we can start to massage into playing well with tailwind's class syntax
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
- #1187 This: 3. Adds a `CardComponentPreview` 4. Sprouts an `ApplicationComponent` which we can start to massage into playing well with tailwind's class syntax <img width="577" alt="Screenshot 2023-03-05 at 6 14 16 PM" src="https://user-images.githubusercontent.com/50284/223004317-f0bf8d69-0c13-40e9-862c-5bf7826f6654.png"> <img width="575" alt="Screenshot 2023-03-05 at 6 14 08 PM" src="https://user-images.githubusercontent.com/50284/223004320-057da756-7d6d-49e1-9691-e81255adff6b.png">
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
- #1187 This is an intermediary step before we look into `LookBook` or similar, but it: 1. Makes it possible to define component previews in `spec/components/previews` 2. Creates a basic layout for showing Components
zspencer
added a commit
that referenced
this issue
Mar 6, 2023
zspencer
added a commit
that referenced
this issue
Mar 7, 2023
- #1187 Now we get even *shinier* components! Such shiny! Very browse! Much wow! I went with the 2.0 beta because I figured it's close to prod.
zspencer
added a commit
that referenced
this issue
Mar 7, 2023
- #1187 This: 3. Adds a `CardComponentPreview` 4. Sprouts an `ApplicationComponent` which we can start to massage into playing well with tailwind's class syntax <img width="577" alt="Screenshot 2023-03-05 at 6 14 16 PM" src="https://user-images.githubusercontent.com/50284/223004317-f0bf8d69-0c13-40e9-862c-5bf7826f6654.png"> <img width="575" alt="Screenshot 2023-03-05 at 6 14 08 PM" src="https://user-images.githubusercontent.com/50284/223004320-057da756-7d6d-49e1-9691-e81255adff6b.png">
zspencer
added a commit
that referenced
this issue
Mar 7, 2023
- #1187 While attempting to use the `IconButtonComponent` for the `Marketplace::Cart::DeliveryAddress#update` flow, we realized we didn't have the affordances we needed to adjust the component. So we introduced a constructor parameter for setting arbitrary classes on the component, which makes it possible for us to adjust the padding/text/background/etc. 🛠️🧹 `Component`: rename `IconButtonComponent` It seems like `ButtonComponent` is a more appropriate name, given that: - It doesn't have any `Icon` *specific* behavior and - It's shorter Co-authored-by: Naomi Quinones <naomiquinones@users.noreply.github.com>
zspencer
added a commit
that referenced
this issue
Mar 7, 2023
- #1187 Now we get even *shinier* components! Such shiny! Very browse! Much wow! I went with the 2.0 beta because I figured it's close to prod.
zspencer
added a commit
that referenced
this issue
Mar 11, 2023
- #1187 This is probably a premature optimization, but I hate writing the entire class name out in template files! I don't know why! It just bothers me!
zspencer
added a commit
that referenced
this issue
Mar 11, 2023
- #1187 This is probably a premature optimization, but I hate writing the entire class name out in template files! I don't know why! It just bothers me!
zspencer
added a commit
that referenced
this issue
Mar 16, 2023
- #1187 A super cool person may want to actually make this a Component, which would be super cool. Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com> Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com> Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com> Co-authored-by: Ross Chapman <rosschapman@users.noreply.github.com>
zspencer
added a commit
that referenced
this issue
Apr 2, 2023
- #1187 - https://turbo.hotwired.dev/handbook/streams#streaming-from-http-responses It turns out that `Turbo` only does turbo-streams when `PUT`/`POST`/`DELETE` are the request methods. If we want to make `GET` requests use the `turbo-stream` request type, we need to specify it in the HTML output, i.e. `<a href="..." data-turbo-stream=true>` I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷
zspencer
added a commit
that referenced
this issue
Apr 2, 2023
- #1187 - https://turbo.hotwired.dev/handbook/streams#streaming-from-http-responses It turns out that `Turbo` only does turbo-streams when `PUT`/`POST`/`DELETE` are the request methods. If we want to make `GET` requests use the `turbo-stream` request type, we need to specify it in the HTML output, i.e. `<a href="..." data-turbo-stream=true>` I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷
zspencer
added a commit
that referenced
this issue
Apr 3, 2023
- #1187 - https://turbo.hotwired.dev/handbook/streams#streaming-from-http-responses It turns out that `Turbo` only does turbo-streams when `PUT`/`POST`/`DELETE` are the request methods. If we want to make `GET` requests use the `turbo-stream` request type, we need to specify it in the HTML output, i.e. `<a href="..." data-turbo-stream=true>` I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷
anaulin
pushed a commit
that referenced
this issue
Apr 3, 2023
- #1187 - https://turbo.hotwired.dev/handbook/streams#streaming-from-http-responses It turns out that `Turbo` only does turbo-streams when `PUT`/`POST`/`DELETE` are the request methods. If we want to make `GET` requests use the `turbo-stream` request type, we need to specify it in the HTML output, i.e. `<a href="..." data-turbo-stream=true>` I wasn't sure if this should be default behavior or not, so I leaned towards making it default to not 🤷
zspencer
added
✨ feature
1 task
Merged
zspencer
added a commit
that referenced
this issue
Aug 15, 2023
- #1187 I tried using `helpers.turbo_frame_tag` in a component and it duplicated the content! Then I found this: ViewComponent/view_component#1099 (comment) And now we can use [`turbo_frame_tag`](https://rubydoc.info/gems/turbo-rails/1.4.0/Turbo/FramesHelper#turbo_frame_tag-instance_method) directly.
zspencer
added a commit
that referenced
this issue
Aug 15, 2023
- #1187 I tried using `helpers.turbo_frame_tag` in a component and it duplicated the content! Then I found this: ViewComponent/view_component#1099 (comment) And now we can use [`turbo_frame_tag`](https://rubydoc.info/gems/turbo-rails/1.4.0/Turbo/FramesHelper#turbo_frame_tag-instance_method) directly.
zspencer
added a commit
that referenced
this issue
Dec 28, 2023
- #1187 This won't do anything in most cases; but if a `CardComponent` is inside of an element with height, such as a `grid`; it will take up the entire thing. It's possible that we should be using `items-stretch` or something?
zspencer
added a commit
that referenced
this issue
Mar 7, 2024
- #1187 - #2271 - #2253 One of the things we've kept bumping into is that each page has to decide how wide it wants to be. That doesn't really seem sustainable or particularly necessary; so now the Layout takes care of: - Providing a Max-Width on every page - Ensuring the Layout is centered horizontally - Ensuring there is appropriate margin from the top of the screen
zspencer
added a commit
that referenced
this issue
Mar 7, 2024
- #1187 - #2271 - #2253 One of the things we've kept bumping into is that each page has to decide how wide it wants to be. That doesn't really seem sustainable or particularly necessary; so now the Layout takes care of: - Providing a Max-Width on every page - Ensuring the Layout is centered horizontally - Ensuring there is appropriate margin from the top of the screen
zspencer
added a commit
to zinc-collective/tobias
that referenced
this issue
Mar 25, 2024
…ective#2281) - zinc-collective#1187 - zinc-collective#2271 - zinc-collective#2253 One of the things we've kept bumping into is that each page has to decide how wide it wants to be. That doesn't really seem sustainable or particularly necessary; so now the Layout takes care of: - Providing a Max-Width on every page - Ensuring the Layout is centered horizontally - Ensuring there is appropriate margin from the top of the screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ContributorsandMaintainers#1520 use the 🌸DesignLibrary#1187 to ease the implementation of 🥔✨Gizmos#709 and provide a consistent user experience.Use Cases
/components!Components
ButtonDesignLibrary:CardComponent#2110DesignLibrary:Pagination#2216DesignLibrary:Formfield hints #2082DesignLibrary:NeighborhoodNavigation#1381The text was updated successfully, but these errors were encountered: