Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔✨ Marketplace: Delivery #1325

Open
3 of 5 tasks
Tracked by #831
zspencer opened this issue Apr 8, 2023 · 0 comments
Open
3 of 5 tasks
Tracked by #831

🥔✨ Marketplace: Delivery #1325

zspencer opened this issue Apr 8, 2023 · 0 comments
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Milestone
1.0 - Andromeda

Comments

@zspencer
Copy link
Member

zspencer commented Apr 8, 2023 •
edited

Use Cases

Design
@zspencer zspencer mentioned this issue Apr 8, 2023
Open
15 tasks
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🌱 Ready for Dev Stuff we are able to move forward on 🥔 Satisfices It's good enough to use, but not particularly great labels Apr 8, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone Apr 8, 2023
@zspencer zspencer changed the title Marketplace: Delivery 🌱🥔 Marketplace: Delivery Apr 8, 2023
@zspencer zspencer changed the title 🌱🥔 Marketplace: Delivery ✨🌱🥔 Marketplace: Delivery Apr 8, 2023
This was referenced Apr 8, 2023
Open
Open
@zspencer zspencer changed the title ✨🌱🥔 Marketplace: Delivery 🌱🥔✨ Marketplace: Delivery Apr 8, 2023
zspencer added a commit that referenced this issue Apr 9, 2023
@zspencer
🥗🧹🥔✨ Marketplace: Show DeliveryArea in `Order::EmailReceiptCompon…
123f169 
…ent`

- #1325
- #1324
- #1326

I didn't use the `marketplace_order, :full` factory outside of the
`Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and
apparently had flubbed the implementation; so that was not working...

So I fixed it and used it in the `Order::EmailReceiptComponent` spec to
test the `Order#delivery_area`

I also noticed we didn't wire in associations between the
`Marketplace::DeliveryArea` into the `Marketplace::Cart` and
`Marketplace::Order` so I added some specs for those.
@zspencer zspencer mentioned this issue Apr 9, 2023
Merged
zspencer added a commit that referenced this issue Apr 9, 2023
@zspencer
🥗🧹🥔✨ Marketplace: Show DeliveryArea in `Order::EmailReceiptCompon…
48b23ea 
…ent`

- #1325
- #1324
- #1326

I didn't use the `marketplace_order, :full` factory outside of the
`Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and
apparently had flubbed the implementation; so that was not working...

So I fixed it and used it in the `Order::EmailReceiptComponent` spec to
test the `Order#delivery_area`

I also noticed we didn't wire in associations between the
`Marketplace::DeliveryArea` into the `Marketplace::Cart` and
`Marketplace::Order` so I added some specs for those.
zspencer added a commit that referenced this issue Apr 9, 2023
@zspencer
🥗🧹🥔✨ Marketplace: Show DeliveryArea in `Order::EmailReceiptCompon…
7c25aa9 
…ent` (#1332)

- #1325
- #1324
- #1326

I didn't use the `marketplace_order, :full` factory outside of the
`Order::PlacedMailerPreview` and `Order::ReceivedMailerPreview`; and
apparently had flubbed the implementation; so that was not working...

So I fixed it and used it in the `Order::EmailReceiptComponent` spec to
test the `Order#delivery_area`

I also noticed we didn't wire in associations between the
`Marketplace::DeliveryArea` into the `Marketplace::Cart` and
`Marketplace::Order` so I added some specs for those.
zspencer added a commit that referenced this issue Apr 17, 2023
@zspencer
🥗 Marketplace: Woops, both Delivery patches worked independently...
b9b032e 
- #1325

I suppose this is why the "Prevent Merging unless Branch is Up To Date
With Upstream" button is a thing...

This should fix the main branch, but I'm curious about what people think
about adding constraints to not allow merging branches that are behind
main?
@zspencer zspencer mentioned this issue Apr 17, 2023
Merged
@zspencer zspencer changed the title 🌱🥔✨ Marketplace: Delivery 🥔✨ Marketplace: Delivery Apr 17, 2023
zspencer added a commit that referenced this issue Apr 17, 2023
@zspencer
🥗 Marketplace: Woops, both Delivery patches worked independently.…
73b5579 
….. (#1378)

- #1325

I suppose this is why the "Prevent Merging unless Branch is Up To Date
With Upstream" button is a thing...

This should fix the main branch, but I'm curious about what people think
about adding constraints to not allow merging branches that are behind
main?
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
3c7bde9 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
@zspencer zspencer mentioned this issue Apr 30, 2023
Merged
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
d6c8d7c 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
2b5efd5 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
fede865 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
🧹 Marketplace: DeliveryConstraints only set in DeliveryArea
1fe029a 
- Prerequisite for #1420

- #1325
- #1136
- #1185

This does not get rid of the reading of the fields; but it does make it
so they are no longer writable; which will make the "stop reading from
them!" PR a bit tidier.
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
19fa3a2 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
@zspencer zspencer mentioned this issue Apr 30, 2023
Merged
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
83318a4 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
🧹 Marketplace: DeliveryConstraints only set in DeliveryArea
07cbf20 
- Prerequisite for #1420

- #1325
- #1136
- #1185

This does not get rid of the reading of the fields; but it does make it
so they are no longer writable; which will make the "stop reading from
them!" PR a bit tidier.
zspencer added a commit that referenced this issue Apr 30, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
7daecf4 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue May 4, 2023
@zspencer
🥗🥔✨🧹 Marketplace: DeliveryConstraints only set in DeliveryArea (#…
44d91e7 
…1422)

🧹 `Marketplace`: `DeliveryConstraint`s only set in `DeliveryArea`

- Prerequisite for #1420

- #1325
- #1136
- #1185

This does not get rid of the reading of the fields; but it does make it
so they are no longer writable; which will make the "stop reading from
them!" PR a bit tidier.
zspencer added a commit that referenced this issue May 4, 2023
@zspencer
Marketplace: Delivery constraints live on DeliveryArea
11f48ef 
- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
zspencer added a commit that referenced this issue May 4, 2023
@zspencer
🥗🧹 Marketplace: Delivery constraints live on DeliveryArea (#1420)
4b292d3 
`Marketplace`: `Delivery` constraints live on `DeliveryArea`

- #1325
- #1136
- #1185

Allowing a `Marketplace` to specify it's delivery fees, constraints,
etc. and a `DeliveryArea` to override them was putting us in a bit of a
mess from "how does data even?!"

This consolidates everything onto `DeliveryArea`, yay!
@zspencer zspencer removed the 🌱 Ready for Dev Stuff we are able to move forward on label May 4, 2023
@zspencer zspencer mentioned this issue May 14, 2023
Merged
This was referenced May 26, 2023
Open
Open
@zspencer zspencer mentioned this issue Jul 26, 2023
Merged
This was referenced Aug 14, 2023
Merged
Open
zspencer added a commit that referenced this issue Aug 17, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
fabddef 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
@zspencer zspencer mentioned this issue Aug 17, 2023
Merged
zspencer added a commit that referenced this issue Aug 24, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
7cb0f6e 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Aug 31, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
f8c2e63 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Aug 31, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
30e56f9 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Aug 31, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
535b629 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Aug 31, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
7a44ad1 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Sep 7, 2023
@zspencer
Marketplace: Begin moving Checkout to it's own page
3261d0c 
- #1672
- #1325
- #1763

This starts to split out the Checkout flow to it's own page; so we can
do things like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Sep 7, 2023
@zspencer
Marketplace: Move Checkout to it's own page
5ca85bd 
- #1672
- #1325
- #1763

This splits out the Checkout flow to it's own page; so we can do things
like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Sep 14, 2023
@zspencer
Marketplace: Move Checkout to it's own page
96105ac 
- #1672
- #1325
- #1763

This splits out the Checkout flow to it's own page; so we can do things
like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???
zspencer added a commit that referenced this issue Sep 15, 2023
@zspencer
🌸✨ Marketplace: Move Checkout to it's own page (#1772)
1a8cc37 
- #1672
- #1325
- #1763

This splits out the Checkout flow to it's own page; so we can do things
like:

- Collect the Delivery Address and Phone Number
- Let the Shopper pick a Delivery Time
- Confirm prices
- ???

* Communicate why we need Shoppers to choose a Delivery Area

* Make pretty! MAKE PRETTY!

* So much pretty

* Remove unnecessary click
zspencer added a commit that referenced this issue Oct 1, 2023
@zspencer
Marketplace: Show delivery fee when Delivery Area is selected
aede7ea 
- #1325

I think this is leftover from when we collected both the address and the
area at the same time.
@zspencer zspencer mentioned this issue Oct 1, 2023
Merged
zspencer added a commit that referenced this issue Oct 2, 2023
@zspencer
✨ Marketplace: Show DeliveryFee when DeliveryArea is selected (#…
501cff3 
…1862)

`Marketplace`: Show delivery fee when Delivery Area is selected

- #1325

I think this is leftover from when we collected both the address and the
area at the same time.
rosschapman pushed a commit that referenced this issue Oct 23, 2023
@zspencer @rosschapman
✨ Marketplace: Show DeliveryFee when DeliveryArea is selected (#…
ee319f9 
…1862)

`Marketplace`: Show delivery fee when Delivery Area is selected

- #1325

I think this is leftover from when we collected both the address and the
area at the same time.
@zspencer zspencer mentioned this issue Dec 19, 2023
Open
2 tasks
@zspencer zspencer mentioned this issue Feb 18, 2024
Open
22 tasks
zspencer added a commit that referenced this issue Feb 18, 2024
@zspencer
🌸 Marketplace: De-italicize-all-things
f9c99c2 
- #831
- #1325
- #2153
- #2215
- #1137
- #2169

@anaulin has mentioned at least twice how she despises italics; but no
one has taken on the task.

So I did a quick skim-through for all the `italic` that lives within the
`Marketplace`, and removed them in place of:

- Making text size smaller
- Making text color grayer
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
@zspencer
🌸 Marketplace: De-italicize-all-things
f637bea 
- zinc-collective#831
- zinc-collective#1325
- zinc-collective#2153
- zinc-collective#2215
- zinc-collective#1137
- zinc-collective#2169

@anaulin has mentioned at least twice how she despises italics; but no
one has taken on the task.

So I did a quick skim-through for all the `italic` that lives within the
`Marketplace`, and removed them in place of:

- Making text size smaller
- Making text color grayer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Milestone
1.0 - Andromeda
Development

No branches or pull requests
1 participant
@zspencer