🐞 Marketplace: Buying Products: Guest Shopper is shown a 404 after Checkout`
#1657
Closed
Assignees
Labels
🐞 bug
Something isn't working
Comments
zspencer
changed the title
Marketplace: guest shopper lands on a 404 after checkoutMarketplace: Guest Shopper is shown a 404 after Checkout
7 tasks
|
I'm planning to work on this either between now and Wednesday or on Wednesday. |
zspencer
added a commit
that referenced
this issue
Jul 20, 2023
- #1657 This allows `Orders` placed by `Guests` to be seen by any `Guest` for 1 week; after which they will 404. There's probably something smerter to do around the `Marketplace::Policy` to use the `Shopper`, which *is* both present and persisted in all cases...
zspencer
added a commit
that referenced
this issue
Jul 20, 2023
- #1326 - #1657 This gives us a system test for guests buying products As we add more things we want to test; we should be able to expand this one test; or re-use some of the helper methods to try different permutations. Bear in mind, CI will need a secret token for stripe; which I should be able to make go.
zspencer
added a commit
that referenced
this issue
Jul 20, 2023
- #1326 - #1657 This gives us a system test for guests buying products As we add more things we want to test; we should be able to expand this one test; or re-use some of the helper methods to try different permutations. Bear in mind, CI will need a secret token for stripe; which I should be able to make go.
zspencer
added a commit
that referenced
this issue
Jul 21, 2023
- #1657 This adjusts the `OrdersController` to use the `Shopper` for the `OrderPolicy::Scope` It's a bit of a hack; but also appears to fix the bug...
zspencer
added a commit
that referenced
this issue
Jul 21, 2023
- #1657 This adjusts the `OrdersController` to use the `Shopper` for the `OrderPolicy::Scope` It's a bit of a hack; but also appears to fix the bug...
zspencer
added a commit
that referenced
this issue
Jul 21, 2023
- #1657 This adjusts the `OrdersController` to use the `Shopper` for the `OrderPolicy::Scope` It's a bit of a hack; but also appears to fix the bug...
zspencer
added a commit
that referenced
this issue
Jul 22, 2023
zspencer
added a commit
that referenced
this issue
Jul 22, 2023
- #1326 - #1657 This gives us a system test for guests buying products As we add more things we want to test; we should be able to expand this one test; or re-use some of the helper methods to try different permutations. Bear in mind, CI will need a secret token for stripe; which I should be able to make go.
zspencer
added a commit
that referenced
this issue
Jul 22, 2023
* 🥗 `Marketplace`: Buying `Products`: System Test - #1326 - #1657 This gives us a system test for guests buying products As we add more things we want to test; we should be able to expand this one test; or re-use some of the helper methods to try different permutations. Bear in mind, CI will need a secret token for stripe; which I should be able to make go. * Listen better to the Stripe * Install stripe cli * Raising is hard * Don't expose the stripe api key on failure * Fix test that got caught in the cross-fire * Update spec/furniture/marketplace/buying_products_system_spec.rb Co-authored-by: Ana Ulin <ana@ulin.org> * Pull `stripe_listen` to it's own thing --------- Co-authored-by: Ana Ulin <ana@ulin.org>
zspencer
added a commit
that referenced
this issue
Jul 23, 2023
- #1657 It felt really weird to me to have a module calling `let` from within the `app` directory; since that's very much an `rspec`-thing. This pulls it out to it's own place; ensures `solargraph` can find the class definition, comments it, and uses it almost everywhere `let(:marketplace)` is used. Again, not sure it's a great / good idea...
zspencer
added a commit
that referenced
this issue
Jul 23, 2023
- #1657 This is a _very weird_ PR; but I think gives us a better interface for building out features in the `Marketplace` because now a `Person` and `Guest` can know about their `Shopper`. There's some stuff that gave me ?!?! while making this work, which I'll do my best to enumerate so we can at least discuss during the review process and reference them in some future git-blame 1. The `Marketplace::CurrentPerson` module feels very weird to me. 2. The `Marketplace::Policy::SpecFactories` really does not want to live where it lives IMO; and it feels like a bit of an obstraction... But it was also very convenient that all the specs that used it were switched to a `Marketplace::Person` and `Marketplace::Guest` at the same time...
zspencer
added a commit
that referenced
this issue
Jul 23, 2023
- #1657 It felt really weird to me to have a module calling `let` from within the `app` directory; since that's very much an `rspec`-thing. This pulls it out to it's own place; ensures `solargraph` can find the class definition, comments it, and uses it almost everywhere `let(:marketplace)` is used. Again, not sure it's a great / good idea...
This was referenced Jul 23, 2023
zspencer
added a commit
that referenced
this issue
Jul 23, 2023
- #1657 It felt really weird to me to have a module calling `let` from within the `app` directory; since that's very much an `rspec`-thing. This pulls it out to it's own place; ensures `solargraph` can find the class definition, comments it, and uses it almost everywhere `let(:marketplace)` is used. Again, not sure it's a great / good idea...
|
I have been able to confirm this through the automated system test; are there any @zinc-collective/contributors interested in double-checking that the fix is "good enough?" If so, assign this issue to yourself and run through placing an order! (Note: This is... not trivial locally due to the need to be connected to If not, I'll close this out next time I'm looking at my assigned issues. |
zspencer
added a commit
that referenced
this issue
Jul 27, 2023
- #1657 This is a _very weird_ PR; but I think gives us a better interface for building out features in the `Marketplace` because now a `Person` and `Guest` can know about their `Shopper`. There's some stuff that gave me ?!?! while making this work, which I'll do my best to enumerate so we can at least discuss during the review process and reference them in some future git-blame 1. The `Marketplace::CurrentPerson` module feels very weird to me. 2. The `Marketplace::Policy::SpecFactories` really does not want to live where it lives IMO; and it feels like a bit of an obstraction... But it was also very convenient that all the specs that used it were switched to a `Marketplace::Person` and `Marketplace::Guest` at the same time...
zspencer
changed the title
Marketplace: Guest Shopper is shown a 404 after CheckoutMarketplace: Buying Products: Guest Shopper is shown a 404 after Checkout`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Marketplace: Buying 🥡Products#1326Marketplace:ShopperOrderHistory#1661After a successful purchase from the Marketplace, a shopper got redirected to their order page (https://marketplace.piikup.com/spaces/piikup/rooms/crumbleandwhisk/marketplaces/4cad5db3-562a-4630-b31d-fc6a253ea5a9/orders/45f6c244-4e32-43c1-aa4b-8e002e278d81?stripe_session_id=cs_live_b1GZZOiJS3UGIqMKQdk5PMAPiwtdA3Me3ZXIYkePdKHoGnGYXRo4mJdtMr), but this page is only visible to logged-in users, so instead they got the standard Rails 404 page.
We should make it so that a successful order confirmation page is visible even if the user is logged-out of Convene, which is going to be the most common case. One way to do this would be to create a separate "order confirmed" page that is visible for logged out users and directs users to log into Convene to see their complete order history.
The text was updated successfully, but these errors were encountered: