-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Marketplace
: order time is displayed in UTC
#1660
Comments
Do you have thoughts on how we can determine the appropriate time zone? Should we just presume PT as the application default for now? Or should we let it be set on the |
I was thinking we could use something like https://github.com/kbaum/browser-timezone-rails to set the timezone for each request. |
Also, we could do one or all of:
|
Converting the value automatically using the browser timezone seems sufficient to me unless Piikup mentioned they wanted configurability to handle some use case? I tend to like an abstraction around 3rd-party lib helpers like |
@rosschapman agreed on starting simple, since nobody has asked for anything special, to the best of my knowledge. I also like the idea of encapsulating the whole thing, although a helper method might be more lightweight than a ViewComponent, just so that in views we can do something like:
instead of:
Although if we use something like the gem I suggested above (which is used by one of the clients I work for), then we don't need to do anything special in views, because it sets the timezone on a per-request basis at the Rails level, so when you display a date in the Rails timezone it shows up in the correct timezone. |
I believe In most of the rails app I work on with time zones; we use Since emails are delivered off the thread that handles requests/responses; I don't know that the browser time zone gem will work quite right to fix this... This leads me to think that for now, having a But I agree, we may want to support person and space level time zones once we start crossing those boundaries. |
Aight, gonna tackle this now. |
- #1660 This is a small step towards a better way for handling time; since we currently only operate out of the SF Bay Area; it seems like a reasonable place to start. At some point we'll want to add in time zone support for browsers, users, spaces, etc. but this gets us to a place where things are a little better sooner rather than later
- #1660 This is a small step towards a better way for handling time; since we currently only operate out of the SF Bay Area; it seems like a reasonable place to start. At some point we'll want to add in time zone support for browsers, users, spaces, etc. but this gets us to a place where things are a little better sooner rather than later
Patch is out: #1706 |
…imes (#1706) `Neighborhood`: Use a default `TimeZone` everywhere - #1660 This is a small step towards a better way for handling time; since we currently only operate out of the SF Bay Area; it seems like a reasonable place to start. At some point we'll want to add in time zone support for browsers, users, spaces, etc. but this gets us to a place where things are a little better sooner rather than later
I'm closing this since it's been in prod for a while and appears to be working well. |
Marketplace
:Order
Notification
s andTimeline
#1331This order was placed at 2:15 AM local time, but in Convene it shows as:
We should try to display this timestamp in the user's timezone (as inferred from the browser).
The text was updated successfully, but these errors were encountered: