Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectionNavigation: Customizing Section links #2037

Open
3 tasks
Tracked by #1988
rosschapman opened this issue Dec 16, 2023 · 3 comments
Open
3 tasks
Tracked by #1988

SectionNavigation: Customizing Section links #2037

rosschapman opened this issue Dec 16, 2023 · 3 comments
Assignees
Labels
✨ feature Reduces Client's Burden or Grants them Benefits

Comments

@rosschapman
Copy link
Contributor

rosschapman commented Dec 16, 2023

Use Case

Marketing and sales

  • Customizing Section link text
  • Customizing Section link icon
  • Customizing Section Link image

Notes

Customizing button color would complement customized images and vendor branding, but that should be considered as part of a larger behavior that introduces theming in a centralized place. See #2037 (comment).

@zspencer
Copy link
Member

I think we should hold off on button color until we actually figure out a way to do theming. Otherwise yea! Letting people change the Text / Icon / Image on a per-SectionLink basis would be great.

P.s. This title appears to overlap significantly with #1961, but I think what it really wants to be is a child of #1988, and it could be rephrased to something like "SectionNavigation: Customizing Section links"

@rosschapman
Copy link
Contributor Author

P.s. This title appears to overlap significantly with #1961, but I think what it really wants to be is a child of #1988, and it could be rephrased to something like "SectionNavigation: Customizing Section links"

I literally forgot to change the title that's all whoops 😆

@rosschapman rosschapman changed the title ✨ Section: Navigation Image ✨ Section: Customizing Section links Dec 18, 2023
@zspencer zspencer changed the title ✨ Section: Customizing Section links SectionNavigation: Customizing Section links Dec 19, 2023
@zspencer
Copy link
Member

I've updated this to indicate that it should be done as part of the SectionNavigation gizmo, and added in customizing the Image as things worth customizing.

@zspencer zspencer added the ✨ feature Reduces Client's Burden or Grants them Benefits label Dec 19, 2023
@rosschapman rosschapman self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Development

No branches or pull requests

2 participants