Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Marketplace: Buying Products - Can't Checkout when only one unarchived DeliveryArea #2198

Closed
Tracked by #1326
zspencer opened this issue Feb 10, 2024 · 1 comment
Closed
Tracked by #1326

🐞 Marketplace: Buying Products - Can't Checkout when only one unarchived DeliveryArea #2198

zspencer opened this issue Feb 10, 2024 · 1 comment
Labels
🐞 bug Something isn't working

Comments

@zspencer
Copy link
Member

zspencer commented Feb 10, 2024 •
edited

@zspencer zspencer changed the title 🐞 Marketplace: Checkout button disappears when there's only one DeliveryArea 🐞 Marketplace: Buying Products - Checkout missing only one DeliveryArea` Feb 10, 2024
@zspencer zspencer mentioned this issue Feb 10, 2024
Open
22 tasks
@zspencer zspencer added the 🐞 bug Something isn't working label Feb 10, 2024
@zspencer zspencer mentioned this issue Feb 10, 2024
Open
1 task
@zspencer zspencer changed the title 🐞 Marketplace: Buying Products - Checkout missing only one DeliveryArea` 🐞 Marketplace: Buying Products - Checkout missing only one DeliveryArea Feb 10, 2024
zspencer added a commit that referenced this issue Feb 10, 2024
@zspencer
🐞🔨Marketplace: Buying Products with one unarchived DeliveryArea
728d3ac 
- #2198

When we added [archiving delivery areas], I didn't take into account
that `Marketplace#cart_for_shopper` was checking against all the
delivery areas.

This fixes that and adds a system spec to make sure we can still
checkout after!

[archiving delivery areas]: #2024
@zspencer zspencer mentioned this issue Feb 10, 2024
Merged
zspencer added a commit that referenced this issue Feb 10, 2024
@zspencer
🐞🔨Marketplace: Buying Products with one unarchived DeliveryArea
65b61bc 
- #2198

When we added [archiving delivery areas], I didn't take into account
that `Marketplace#cart_for_shopper` was checking against all the
delivery areas.

This fixes that and adds a system spec to make sure we can still
checkout after!

[archiving delivery areas]: #2024
zspencer added a commit that referenced this issue Feb 16, 2024
@zspencer
🐞🔨Marketplace: Buying Products with one unarchived DeliveryArea
b1b6406 
- #2198

When we added [archiving delivery areas], I didn't take into account
that `Marketplace#cart_for_shopper` was checking against all the
delivery areas.

This fixes that and adds a system spec to make sure we can still
checkout after!

[archiving delivery areas]: #2024
zspencer added a commit that referenced this issue Feb 16, 2024
@zspencer
🐞🔨Marketplace: Buying Products with one unarchived DeliveryArea
b275438 
- #2198

When we added [archiving delivery areas], I didn't take into account
that `Marketplace#cart_for_shopper` was checking against all the
delivery areas.

This fixes that and adds a system spec to make sure we can still
checkout after!

[archiving delivery areas]: #2024
@zspencer
Copy link
Member Author

I've confirmed that this works on production again!

@zspencer zspencer changed the title 🐞 Marketplace: Buying Products - Checkout missing only one DeliveryArea 🐞 Marketplace: Buying Products - Can't Checkout when only one unarchived DeliveryArea Feb 17, 2024
zspencer added a commit to zinc-collective/tobias that referenced this issue Mar 25, 2024
@zspencer
🐞🔨Marketplace: Buying Products with one unarchived DeliveryArea
7d98274 
- zinc-collective#2198

When we added [archiving delivery areas], I didn't take into account
that `Marketplace#cart_for_shopper` was checking against all the
delivery areas.

This fixes that and adds a system spec to make sure we can still
checkout after!

[archiving delivery areas]: zinc-collective#2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer