New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin may manage Client, Workspace, and People data #104
Admin may manage Client, Workspace, and People data #104
Conversation
}, | ||
"ADMIN_PASSWORD": { | ||
"description": "Password to access the admin panel", | ||
"generator": "secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about generator
, pretty convenient.
docker-compose.yml
Outdated
environment: | ||
POSTGRES_PASSWORD: password | ||
ports: | ||
- 5432:5432 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this docker file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally committed it. One of my computers does not have postgresql-server installed; so the docker-compose.yml
file allows me to spin up the service-level dependencies without installing postgresql.
Probably needs it's own PR with documentation updates as well.
# you're free to overwrite the RESTful controller actions. | ||
module Admin | ||
class ApplicationController < Administrate::ApplicationController | ||
extend Configuration::Configurable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this on review app: Unable to load application: NameError: uninitialized constant ActiveSupport::Configurable::Configuration::Configurable
, possible name collision with Rails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to require 'admin/configuration'
, lib
isn't in auto load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I was doing this on my ipad, which does not (yet) let me view the Heroku logs so I couldn't figure out why the build was failing!
57c9fbd
to
f810951
Compare
f810951
to
7071d3d
Compare
7071d3d
to
655f38d
Compare
655f38d
to
151b346
Compare
151b346
to
311a843
Compare
311a843
to
65545fe
Compare
See: #103 This is a very rough draft, and is only intended to give us a baseline to start with so I stop going into heroku rails console to manage rooms and such.
I worry about `ENV` variables leaking everywhere, so I'm prematurely sprouting a Configuration class in the Admin namespace so that there is a single-ish place where `ENV` variables are consumed. This also sprouts `app/lib` to hold non-pattern-focused objects in an auto-loadable area. See: https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#autoload-paths
65545fe
to
43ce625
Compare
Looks great and tested on review app. |
Because some of our models use friendly slugs and some do not, I overrode the scoped_resources method to take that into account. I also did some re-arranging of the data on the Workspace and Client dashboards to make them a bit more user-friendly
98bcea9
to
18b07ef
Compare
Yeaaaaaa, turns out I had overlooked some of the stuff regarding linking. I've fixed that, and also did some cleanup of the dashboards. Thanks! Going to merge when tests pass! |
See: #103
This is a very rough draft, and is only intended to give us a baseline
to start with so I stop going into heroku rails console to manage rooms
and such.