🐞 Marketplace: DeliveryWindow gracefully handles strings
#1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://zinc-collective.sentry.io/issues/4031191037/?project=6052513 - #1265 - #1185 - #1269 So, it turns out the reason we were getting these errors was because I had not made the form picker smart enough to use the string value when a delivery window was not present. Now it is! Also, reverting the StoreModel stuff because it did not seem to fix the problem and I can't figure out why it's not working :'(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace: ActionView::Template::Error: undefined method `strftime' for "BETWEEN 4:30 PM - 6PM":String #1265Marketplace:DeliveryConstraints #1185Marketplace: ActionView::Template::Error: undefined method `delivery_window' for {"order_by"=>"Wednesday at 5PM", "notify_emails"=>"hello+p... #1269So, it turns out the reason we were getting these errors was because I
had not made the form picker smart enough to use the string value when a
delivery window was not present.
Now it is!
Also, reverting the StoreModel stuff because it did not seem to fix the
problem and I can't figure out why it's not working :'(