[#1472] Replace "Room" with "Section" #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locales files with Section and Sections Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com> Co-authored-by: Ana <anaulin@users.noreply.github.com> Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com>
9 tasks
zspencer
approved these changes
May 18, 2023
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| <div> | |||
| <%- if current_room && policy(current_room).edit? %> | |||
| <%= link_to t('icons.edit'), [:edit, current_space, current_room], class: 'no-underline', aria: { label: "Configure Room"} %> | |||
| <%= link_to t('icons.edit'), [:edit, current_space, current_room], class: 'no-underline', aria: { label: "Configure Section"} %> | |||
There was a problem hiding this comment.
Maybe not for this PR, but it would be nice to pull this out to config/locales/rooms/en.yml and place it somewhere like rooms.edit.link_to (you'll want to figure out where we put theedit.link_to text in other spots)
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| <footer> | |||
| <%= link_to [:new, space, :room] do %> | |||
| <span class="icon --add" role="img" aria-label="Add"></span>Add New Room | |||
| <span class="icon --add" role="img" aria-label="Add"></span>Add New Section | |||
There was a problem hiding this comment.
This could live at rooms.new.link_to in locales/rooms/en.yml
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| <fieldset> | |||
| <header> | |||
| <h3>Rooms</h3> | |||
| <h3>Sections</h3> | |||
There was a problem hiding this comment.
I don't know if we have a pattern yet for how we localize headers of pages but I wish we did.
KellyAH
added
馃Ч refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1472
Replace "Room" with "Section" in customer facing UI.
Rooms List Page
create room form
edit room form
Tests
Confirmed pages render on local with text changes.
Can create and edit a room/section.
馃悰 cannot Delete a room/section