🌸✨ `Marketplace`: UI to manage `Order::NotificationMethod` #1562

zspencer · 2023-06-15T01:41:15Z

🥔✨ Marketplace: Managing Order::NotificationMethods #1511

This is basically a copy-paste from Marketplace::DeliveryArea, so it is ripe for testing via the delivery_area_request_spec.rb

TODO:

After

zspencer · 2023-06-15T01:41:48Z

app/components/svg_component.rb

@@ -6,6 +6,7 @@ class SvgComponent < ApplicationComponent
    gear: :gear,
    map: :map,
    receipt_percent: :receipt_percent,
+    letter: :receipt_percent,


This should probably be a better SVG than the receipt one...

the ICON_MAPPINGS was named letter so I replaced it with letter icon in 85514fd

But, since the icon is applied to a notification menu, I felt a bell icon worked better, thus I added it in a3e90d9.

Please choose which on you want or suggest other icon suggestions.

Oh I see now, it's notification via email. Hm maybe the open_letter icon works better than.

Maybe we should also change the Order Notifications text to a clearer Order Email Notifications 🤔

Well, it's notifications via email... for now; but if you check the Order Notifications and History we do have plans to include at the very least Square Point of Sale; and maybe even SMS!

Also, I love the bell!

zspencer · 2023-06-15T01:42:22Z

app/furniture/marketplace/breadcrumbs.rb

+  parent :marketplace_order_notification_methods, order_notification_method.marketplace
+  link t("marketplace.order_notification_methods.edit.link_to", contact_location: order_notification_method.contact_location)
+  order_notification_method.marketplace.location(child: :order_notification_methods)
+end


One day we will not have to define crumbs because we have made them so consistent that we can just infer wht the crumb should be...

ONE DAY....

app/furniture/marketplace/marketplaces/edit.html.erb

zspencer · 2023-06-15T01:43:34Z

app/furniture/marketplace/order_notification_method_component.rb

+    def edit_button
+      super(title: t("marketplace.order_notification_methods.edit.link_to", contact_location: contact_location),
+            href: order_notification_method.location(:edit))
+    end


It would be nice if #edit_button, #edit_button?, #destroy_button, and #destroy_button? could be part of a RecordComponent or something so we don't have to define them every time.

app/furniture/marketplace/order_notification_methods_controller.rb

zspencer · 2023-06-28T22:20:46Z

~~I'm going to split out the addition of the OrderNotification page from the creation of the OrderNotification model; since that is a small enough concrete step.~~

zspencer · 2023-06-28T23:35:36Z

app/furniture/marketplace/order/notification_methods_controller.rb

+        end.tap do |order_notification_method|
+          authorize(order_notification_method)
+        end
+      end


I feel like this could be replaced across almost all our controllers with decent_exposure

zspencer · 2023-06-29T00:09:17Z

In an ideal world; we would not need nearly this much ceremony to sprout the CRUD UI for a new model. We would need to define the Model, ModelController, ModelPolicy, ModelPolicy::Scope, ModelComponent and Model::FormComponent and the appropriate locales and routes; but breadcrumbs and most, if not all, of the views should be pretty standardized.

I'm not sure if it's prudent for me to do that now-right-now; but I am very tempted to take a refactor pass because basic CRUD should not require 300 lines of code :-p.

anaulin

Thank you!

app/furniture/marketplace/breadcrumbs.rb

- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`

Co-authored-by: KellyAH <KellyAH@users.noreply.github.com>

Interestingly enough, to `button` method pointed out a problem with putting the `Order::NotificationMethod`, in that the *routing* to the `notification_methods` is not in the `order`; which was causing the inferred translation lookup to go squiggly. I took the hint and pulled it out of the `Order` namespace.

zspencer · 2023-07-06T00:46:51Z

db/migrate/20230615002110_add_marketplace_notification_methods.rb

  def change
-    create_table :marketplace_order_notification_methods, id: :uuid do |t|
+    create_table :marketplace_notification_methods, id: :uuid do |t|


🤦 I did a silly

zspencer commented Jun 15, 2023

View reviewed changes

zspencer marked this pull request as draft June 15, 2023 01:46

zspencer assigned KellyAH Jun 15, 2023

zspencer changed the title ~~Marketplace: UI to manage OrderNotificationMethod~~ 🌸✨ Marketplace: UI to manage OrderNotificationMethod Jun 15, 2023

zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🌸 Polish Improves the UX! labels Jun 15, 2023

Base automatically changed from marketplace/improve-order-notification-ui to main June 15, 2023 02:32

zspencer changed the title ~~🌸✨ Marketplace: UI to manage OrderNotificationMethod~~ 🌸✨ Marketplace: UI to manage Order::NotificationMethod Jun 15, 2023

zspencer mentioned this pull request Jun 16, 2023

🐞 Clicking "Remove Gizmo 🗑️" button from a Gizmo's edit page does not actually remove the Gizmo from the Section #1565

Closed

3 tasks

zspencer mentioned this pull request Jun 28, 2023

🌸✨ Component: Add bell option to SvgComponent #1614

Merged

zspencer changed the base branch from main to components/add-bell-to-svg-component June 28, 2023 22:54

zspencer commented Jun 28, 2023

View reviewed changes

zspencer force-pushed the components/add-bell-to-svg-component branch from 155996c to 36545a7 Compare June 28, 2023 23:53

zspencer force-pushed the marketplace/order-notification-method-ui branch from df841cc to 46052e0 Compare June 28, 2023 23:55

zspencer force-pushed the components/add-bell-to-svg-component branch from 36545a7 to 1a9fe75 Compare June 29, 2023 00:11

zspencer force-pushed the marketplace/order-notification-method-ui branch from 8568bce to 97ff810 Compare June 29, 2023 00:14

Base automatically changed from components/add-bell-to-svg-component to main June 29, 2023 00:33

zspencer marked this pull request as ready for review June 29, 2023 00:33

zspencer force-pushed the marketplace/order-notification-method-ui branch from 97ff810 to 621b907 Compare June 29, 2023 00:33

zspencer requested review from a team and KellyAH June 29, 2023 00:40

zspencer assigned zspencer and unassigned KellyAH Jun 29, 2023

zspencer force-pushed the marketplace/order-notification-method-ui branch from 621b907 to 29f34bc Compare June 29, 2023 01:40

anaulin approved these changes Jun 29, 2023

View reviewed changes

KellyAH reviewed Jun 29, 2023

View reviewed changes

app/furniture/marketplace/breadcrumbs.rb Outdated Show resolved Hide resolved

zspencer and others added 2 commits June 30, 2023 20:41

Update app/furniture/marketplace/breadcrumbs.rb

63ac99c

Co-authored-by: KellyAH <KellyAH@users.noreply.github.com>

zspencer force-pushed the marketplace/order-notification-method-ui branch from fc1429b to 0995f7c Compare July 1, 2023 04:14

Alphabetize the routes

f3903b7

zspencer merged commit d1ba3f7 into main Jul 1, 2023
4 checks passed

zspencer deleted the marketplace/order-notification-method-ui branch July 1, 2023 04:20

zspencer commented Jul 6, 2023

View reviewed changes

zspencer mentioned this pull request Jul 6, 2023

🐞🔨🧹 Marketplace: Fix fumbled rename #1638

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌸✨ `Marketplace`: UI to manage `Order::NotificationMethod` #1562

🌸✨ `Marketplace`: UI to manage `Order::NotificationMethod` #1562

zspencer commented Jun 15, 2023 •

edited

zspencer Jun 15, 2023

KellyAH Jun 21, 2023

KellyAH Jun 21, 2023

zspencer Jun 21, 2023

zspencer Jun 21, 2023

zspencer Jun 15, 2023

zspencer Jun 15, 2023

zspencer commented Jun 28, 2023 •

edited

zspencer Jun 28, 2023

rosschapman Jun 29, 2023

zspencer commented Jun 29, 2023

anaulin left a comment

zspencer Jul 6, 2023

🌸✨ Marketplace: UI to manage Order::NotificationMethod #1562

🌸✨ Marketplace: UI to manage Order::NotificationMethod #1562

Conversation

zspencer commented Jun 15, 2023 • edited

TODO:

After

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zspencer commented Jun 28, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zspencer commented Jun 29, 2023

anaulin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

🌸✨ `Marketplace`: UI to manage `Order::NotificationMethod` #1562

🌸✨ `Marketplace`: UI to manage `Order::NotificationMethod` #1562

zspencer commented Jun 15, 2023 •

edited

zspencer commented Jun 28, 2023 •

edited