Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about renames of Room and Furniture #1571

Merged
merged 2 commits into from
Jun 18, 2023
Merged

docs: add note about renames of Room and Furniture #1571

merged 2 commits into from
Jun 18, 2023

Conversation

KellyAH
Copy link
Contributor

@KellyAH KellyAH commented Jun 18, 2023 •
edited

Change Ana reccomended for discussion

  • add note at the top of each doc mentioning that Furniture has been renamed to Gizmo
  • add note at the top mentioning that Room has been renamed to Section
Screenshot 2023-06-18 at 8 01 26 AM Screenshot 2023-06-18 at 8 02 11 AM Screenshot 2023-06-18 at 8 04 23 AM Screenshot 2023-06-18 at 8 05 40 AM

KellyAH
KellyAH commented Jun 18, 2023
View reviewed changes
CONTRIBUTING.md
@@ -32,6 +32,7 @@ Stakeholders for `Convene` fall into one or more of the following categories:
- [`Operators`], who steward the [`Neighborhood`: Infrastructure], [`Neighborhood`: Trust & Safety], and [`Client`: Support] responsibilities
- [`Contributors`] and [`Maintainers`], who design and build [`Furniture`].

Note: `Furniture` has been renamed to `Gizmo/Gizmos`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add the note to a LOT of places. Maybe it's overkill. what to ya'll think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, especially since you already did it!

anaulin
anaulin approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping make our docs less confuzzling!

@KellyAH KellyAH merged commit 4a3ab62 into main Jun 18, 2023
4 checks passed
@KellyAH KellyAH deleted the 1472-update-docs-with-Section-and-Gizmo branch June 18, 2023 20:51
@KellyAH
Copy link
Contributor Author

KellyAH commented Jun 18, 2023

main merge CI: https://github.com/zinc-collective/convene/actions/runs/5305672321

@zspencer
Copy link
Member

Thank you @KellyAH !!! This is great!

@KellyAH KellyAH mentioned this pull request Jun 20, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KellyAH @zspencer @anaulin