Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌸 Marketplace: Checkout button is not shown until you can Checkout #1999

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Dec 5, 2023

It feels odd that we have a Checkout button when you can't click it.

Screen.Recording.2023-12-04.at.7.13.36.PM.mov

- #1326
- #1983 (comment)

It feels odd that we have a `Checkout` button when you can't click it.
@anaulin
Copy link
Member

anaulin commented Dec 5, 2023

What is the experience when you have products but did not select a delivery area?

I'm concerned that a button that appears/disappears without explanation is no less confusing than having the button look enabled but then not work. We should at least have some way to communicate to the shopper that in order to checkout they need to (1) select a delivery area, and (2) add products in order to be able to initiate checkout.

Ideally the button would become grayed out or some other visual indication that it is "not available yet", with an explanation of why ("add products to initiate checkout", or "select delivery area to initiate checkout"). (Unrelated to this PR, maybe the selection of delivery area should happen after you initiate checkout anyway, together with entering the delivery address.)

Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the quick iteration on this, thank you!

I am all for merging this PR and then iterating to make the button a little less Dave Copperfield-y.

@zspencer
Copy link
Member Author

zspencer commented Dec 5, 2023

What is the experience when you have products but did not select a delivery area?

Right now there's another bug where updating the DeliveryArea doesn't update the Cart; which basically means that the Checkout button doesn't show up until they change their Cart in other ways. It's annoying; but is going to exist if we disable / enable or hide / show.

My hope is to get a bit further on splitting the Cart interface from the Menu interface; which should both eliminate the error and actually make things better.

I'm concerned that a button that appears/disappears without explanation is no less confusing than having the button look enabled but then not work. We should at least have some way to communicate to the shopper that in order to checkout they need to (1) select a delivery area, and (2) add products in order to be able to initiate checkout.

Ideally the button would become grayed out or some other visual indication that it is "not available yet", with an explanation of why ("add products to initiate checkout", or "select delivery area to initiate checkout").

Agreed. I'm tilting at that next.

(Unrelated to this PR, maybe the selection of delivery area should happen after you initiate checkout anyway, together with entering the delivery address.)

I think it is probably better to have them pick their Delivery Area prior to showing the Menu since the delivery schedule is tied to the area; and picking an entire catering order only to find out you can only get stuff delivered on Friday probably won't feel great.

@zspencer zspencer merged commit 53b7843 into main Dec 5, 2023
4 checks passed
@zspencer zspencer deleted the marketplace/checkout-dont-show-checkout-unless-you-can-checkout branch December 5, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌸 Polish Improves the UX!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants