Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better configure Passwordless, add an initializer #220

Merged
merged 1 commit into from Apr 3, 2021
Merged

Better configure Passwordless, add an initializer #220

merged 1 commit into from Apr 3, 2021

Conversation

anaulin
Copy link
Member

@anaulin anaulin commented Apr 3, 2021

This PR addresses some of the issues we uncovered when doing manual testing for #118:

  • add a better "from" address for magic link emails
  • set an explicit token timeout setting
  • set explicit sign in, sign out, and failure redirect paths
  • add an explicit setting for redirecting "back" after sign in (where possible)

@anaulin
Configure Passwordless with an initializer
c6a73f7 
Adds:
* a better "from" address for magic link emails
* explicit token timeout setting
* explicit sign in, sign out, and failure redirect paths
* explicit setting for redirecting "back" after sign in (where possible)
@anaulin anaulin requested a review from a team April 3, 2021 23:04
@user512 user512 temporarily deployed to convene-pr-220 April 3, 2021 23:04 Inactive
user512
user512 approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@user512 user512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zspencer
zspencer approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@zspencer zspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@zspencer zspencer added this to the Cleanup! milestone Apr 3, 2021
@zspencer zspencer merged commit f0325a3 into development Apr 3, 2021
@zspencer zspencer deleted the 118/passwordless-configuration branch April 3, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zspencer zspencer zspencer approved these changes

@user512 user512 user512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Contributor Experience!
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anaulin @zspencer @user512