Furniture: Spotlight! #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaulin
force-pushed
the
ensemble/feature--image-furniture
branch
from
d214597
to
a286acd
Compare
zspencer
force-pushed
the
ensemble/feature--image-furniture
branch
from
69714fa
to
d09768d
Compare
anaulin
force-pushed
the
ensemble/feature--image-furniture
branch
from
4583d45
to
376674a
Compare
Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
Rails Model => Route inference is notoriously bad when dealing with singular resources. This sidesteps that by now by shifting so that the EmbeddedImage can have many image files.
This builds on the infrastructure defined in the [Furniture: Livestream - Owncast!](https://github.com/zinc-collective/convene/pull/669/files) patch, which probably should be merged first (or I should decompose the supporting bits) Essentially, the "Image" furniture is a great start, but I'm hoping to shift our design from the technical to the marketing / designer friendly use-case. Ideally, a Spotlight isn't just a hero image, but can also support the little "Here's an icon + summary + call to action" that many sites use to specify their value propositions. By making the Spotlight responsible for exposing affordances like alt-text, focal point, aspect ratio, etc. we can give folks who are being intentional about the presentation of their digital storefront with super-powers that help them get better conversion.
Co-authored-by: <zspencer@users.noreply.github.com>
Co-authored-by: <zspencer@users.noreply.github.com>
Co-authored-by: <zspencer@users.noreply.github.com>
This may be a bit risky, but the intention here is to make all Furniture live inside a Turbo Frame, so the "modify in-line" behavior "just works" Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
* A step closer to inflating and confirming Furniture in Features * Get rid of unnecessary parameterTypes * Pull back from moving to a hidden _attributes It wasn't working anyway * Sending Furniture over the wire kinda works. * Consolidate on the less json-y way to set furnitur attributes Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
Co-authored-by: <zspencer@users.noreply.github.com>
Co-authored-by: <zspencer@users.noreply.github.com>
anaulin
force-pushed
the
ensemble/feature--image-furniture
branch
4 times, most recently
from
e37ea60
to
b400eda
Compare
Co-authored-by: <zspencer@users.noreply.github.com>
anaulin
force-pushed
the
ensemble/feature--image-furniture
branch
from
b400eda
to
f71484d
Compare
zspencer
reviewed
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
image_filetoimage