Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Image "Develops" after photographs #27

Open
zspencer opened this issue Apr 18, 2021 · 11 comments
Open

No Image "Develops" after photographs #27

zspencer opened this issue Apr 18, 2021 · 11 comments
Assignees
@theInternauts
Labels
bug Something isn't working
Milestone
ShakeItPhoto - Ev...

Comments

@zspencer
Copy link
Member

My instincts are there is a race condition somewhere in the process; and since the photo saves as expected this may not be urgent. Going to bucket it into 3.3.0 for now.

Subject: No image develops
Message: Thank you for updating ShakeItPhoto! I love this app. The only problem I have encountered is that many times, when "developing" a pre-existing photo on my phone, it develops into a completely black image. Not every time, but sometimes. However, the proper photo is always put into my camera roll. It would be great if you could fix this bug in a future update.
I enjoy this app tremendously and really appreciate that you guys created it and are maintaining it again. Thank you!
@zspencer zspencer added the bug Something isn't working label Apr 18, 2021
@zspencer zspencer added this to the ShakeItPhoto 3.3.0 milestone Apr 18, 2021
@theInternauts
Copy link
Contributor

I'll keep an eye out for this one.

@theInternauts theInternauts self-assigned this Jan 26, 2022
@theInternauts
Copy link
Contributor

@zspencer we don't have any information about the iOS version or device from this user, do we?

@zspencer
Copy link
Member Author

No, but I would hope that we could learn how to instrument the applications such that when error reports come in we can trace them back somehow. Right now, we have a Sentry account and a Firebase account; but I am not familiar enough with the iOS EcoSystem to know how it all plays together. Perhaps check with @user512 about what he's seen?

@theInternauts
Copy link
Contributor

I think I can recreate the bug; but only intermittently.... If you use the camera and capture a photo every executes as it should. But, sometimes (not always) choosing an image from the on-device photo library will result in the image not "developing" on screen even though it will still be processed and saved into the library on-device. I am not sure; but it seems like the "developing" failure occurs with lighter images--that could be my imagination, though.

@theInternauts
Copy link
Contributor

Note to self: it appears to be a race condition. It's hard to reproduce. Choose an image from the image picker to "develop" and, BEFORE the animation completes, quickly choose the newly created, resulting image from the image picker to re-develop as quickly as possible . If you wait for the second development process you may see the empty frame.

Best guess: this is probably related to multithreading and a background process. More later.

NOTE TO CONTRIBUTORS: Please let me know if I'm too chatty in these comments. I can record my troubleshooting train-of-thought elsewhere if this is too verbose.

@zspencer
Copy link
Member Author

Nope! This is perfect! Keep the notes flowin'!

@theInternauts theInternauts mentioned this issue Mar 13, 2022
Closed
@theInternauts theInternauts mentioned this issue Oct 18, 2022
Merged
@zspencer
Copy link
Member Author

New Report:

1.some photos gets all black results as the screenshots(it’s ok in the album)

https://groups.google.com/a/zinc.coop/g/momentpark/c/XYafyTpka-w/m/7P27oigLDgAJ

@theInternauts
Copy link
Contributor

theInternauts commented Dec 17, 2022 via email

@zspencer
Copy link
Member Author

No worries and no rush, we move at the speed we can safely move at.

@ErnieBarreto
Copy link

Hi, I sent in the original comment. I still get the error in this latest update (version 3.5.0).
I currently run the app on an iPhone 13 pro with iOS 16.4.1(a).
Note that I never use the camera within the app. I only ever import from my camera roll. The app usually works fine for several photos and then when the black "developed" image appears, it stays that way until I swipe the app away.

@zspencer
Copy link
Member Author

zspencer commented Jun 1, 2023

Hey @ErnieBarreto thanks, that is useful! We'll keep trying to isolate and fix it!

theInternauts added a commit that referenced this issue Sep 30, 2023
@theInternauts
issue #27 - explicitly update the frame of the developed view to matc…
0bb7ab7 
…h the undeveloped view and polaroid frame
@theInternauts theInternauts mentioned this issue Sep 30, 2023
Merged
theInternauts added a commit that referenced this issue Oct 2, 2023
@theInternauts
Bugfix/remove gray line in render (#48)
25027b9 
* issue #47 - remove forced size override. It was perturbing the position calculations in other methods. Need units.
* remove dead code AND ensure that the photo picker can be cancelled cleanly
* Create a method to encapsulate hiding/showing the toolbar in a clear and readable way.  Migrated to Swift.
* extend NSItemProvider to support properly WebP format (PNG-based and JPEG-based)
* use weak reference to avoid retain cycle/memory leak
* issue #27 - explicitly update the frame of the developed view to match the undeveloped view and polaroid frame
* clean up: no longer need these statements (they were for debugging/troubleshooting).
* super basic launch screen so the app reviewers don't deny the binary for using the 'old way'
* Switch to SPM for Sentry integration (because of a cocoa pods bug that was preventing the release build with Xcode 15 on Sonoma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theInternauts theInternauts

Labels
bug Something isn't working
Projects
None yet
Milestone
ShakeItPhoto - Eventually
Development

No branches or pull requests
3 participants
@zspencer @theInternauts @ErnieBarreto