This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
🗃 Sprout Team Member Model #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Small tweaks to scenario to make it terser - Initial model, factories, and spec file - Apply the migration and schema
We're relying on thoughtbot's shoulda matchers, because they're a well maintained set of expectation handlers that allow us to fluently describ a bunch of the validations that are built into Rails.
We like our seed files to give us a decent starting point for local development, as well as to be idempotent. This ensures that when we pick the project up in the future, we have a useful set of data to work with on our local machine without having to pull data from production.
zspencer
merged commit 6844e86
into
13/first-pass-at-team-member-may-establish-available-calendar-times
cjoulain
pushed a commit
that referenced
this pull request
May 4, 2020
…ar Invite (#24) * 🔧✅ Test creating an available time slot via calendar invite See: #13 Also updates the default test script so that it doesn't try and run the work that is in progress when running feature tests. * 🗃✅🌱🔧 Sprout Team Member Model (#26) * 🗃 Sprout Team Member Model - Small tweaks to scenario to make it terser - Initial model, factories, and spec file - Apply the migration and schema * ✅ Validate presence and uniqueness of the team member attributes We're relying on thoughtbot's shoulda matchers, because they're a well maintained set of expectation handlers that allow us to fluently describ a bunch of the validations that are built into Rails. * 🌱🔧 Seed a TeamMember when running db:seeds locally We like our seed files to give us a decent starting point for local development, as well as to be idempotent. This ensures that when we pick the project up in the future, we have a useful set of data to work with on our local machine without having to pull data from production. * 🔧✅ Sprout apiClient driver for feature tests We rely on drivers to interact with the system under test because that gives us a seam to implement API clients while we work forward. This prevents the common anti-pattern where a projects API and other implementation run faster than the documentation, api client, etc. It's not a panacea; but it gives us the affordances to notice when these test + document + implement gaps begin to emerge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweaks to scenario to make it terser
Initial model, factories, and spec file
Apply the migration and schema
Add validations for uniqueness
Add seeds for test purposes