Apply feedback on Convene's landing page #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
convene/apply-feedback-on-landing-page
branch
from
685370f
to
0af19b5
Compare
See: zinc-collective/convene#8 Colombene pointed out that we could add more information to the title element for discoverability-goodness.
See: zinc-collective/convene#8 This isn't perfect, but it's built from the [positioning statement] and conversation(s) I've been following in the Google Docs and Slack. Plan is to replace the copy with the words that Colombene or Maxwell put in the [landing site copy] [positioning statement]: https://docs.google.com/document/d/1t8RLN-m6FYXG6UjO6t0enxPc8cZEVneHZby0rSt35UI/edit [landing site copy]: https://docs.google.com/document/d/164RepjCMVhVmk--bvAXvRaDVxvLAloZE8wYMAmUv0e0/edit?usp=drive_web&ouid=109885491663234077023
zspencer
force-pushed
the
convene/apply-feedback-on-landing-page
branch
from
0af19b5
to
b31cf36
Compare
9 tasks
user512
approved these changes
May 22, 2020
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| layout: layouts/product-landing-page.njk | |||
| title: Convene | |||
| subtitle: Bringing Workers Together | |||
| summaryText: Anim aute id magna aliqua ad ad non deserunt sunt. Qui irure qui lorem cupidatat commodo. Elit sunt amet fugiat veniam occaecat fugiat aliqua. | |||
| subtitle: — Video-based Online Collaboration Tools | |||
There was a problem hiding this comment.
Is &mdash a unicode for a dash? I am just curious on why isn't it showing on the screenshot.
There was a problem hiding this comment.
Ah, I think it's getting stripped out. It's a unicode symbol for an em-dash
maximegalon5
requested review from
maximegalon5
and removed request for
maximegalon5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per, @maximegalon5, I've removed references to client ownership (since we're not really ready to do that yet)
Per @colombene I've updated the title to be a bit more discoverable and to try and include other parts of our core differentiator(s) from the positioning statement work she did.
I've been using https://docs.google.com/document/d/164RepjCMVhVmk--bvAXvRaDVxvLAloZE8wYMAmUv0e0/edit for the "starting point" for copy; and am happy to apply changes to this page if folks aren't comfortable doing so themselves, or figure out a way to pull in content so we don't have to use github to manage the application of copy-changes.