Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not circumvent DVC filesystem #301

Closed
PythonFZ opened this issue May 22, 2024 · 1 comment
Closed

Do not circumvent DVC filesystem #301

PythonFZ opened this issue May 22, 2024 · 1 comment

Comments

@PythonFZ
Copy link
Member

First highlighted here, there should never be an exception to not go through the DVCFileSystem.

That is a good point. Actually I modified the ProcessAtoms base class which also uses that line, and have to admit that I don't know if it is needed. Maybe we can talk about the atoms and file handling so I can adjust this in the base class too?

Originally posted by @Tetracarbonylnickel in #299 (comment)
Tetracarbonylnickel added a commit that referenced this issue Jun 19, 2024
@Tetracarbonylnickel
fix issue #301
7854a6b
@Tetracarbonylnickel Tetracarbonylnickel mentioned this issue Jun 24, 2024
Merged
@Tetracarbonylnickel
Copy link
Contributor

resolved with PR #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PythonFZ @Tetracarbonylnickel