Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests fail on main #510

Closed
christophlohrmann opened this issue Mar 10, 2022 · 1 comment · Fixed by #512
Closed

tests fail on main #510

christophlohrmann opened this issue Mar 10, 2022 · 1 comment · Fixed by #512
Labels
p0-urgent Must be fixed immediately.

Comments

@christophlohrmann
Copy link
Collaborator

Tests fail because DataHub has changed.

Possible solution: Make it such that you can use specific versions of DataHub and MDSuite says which version it needs.
With that you can change Datahub (and reflect the update with a version change in a PR on mdsuite) without affecting any other branch of mdsuite.
@christophlohrmann christophlohrmann mentioned this issue Mar 11, 2022
Merged
@christophlohrmann christophlohrmann added the p0-urgent Must be fixed immediately. label Mar 11, 2022
@christophlohrmann christophlohrmann mentioned this issue Mar 11, 2022
Open
@PythonFZ
Copy link
Member

Will be fixed by introducing tag in zincware/ZincHub#3

This will require the keyword tag on all occurrences of zinchub. It will also prohibit using data straight from main and instead require a new tag for all changes, ideally providing a description on why the data was updated.

@PythonFZ PythonFZ mentioned this issue Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p0-urgent Must be fixed immediately.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tag to zinchub.DataHub zincware/MDSuite
2 participants
@PythonFZ @christophlohrmann