Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save meta.Text in zntrack.json #567

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Apr 5, 2023

No description provided.

@PythonFZ PythonFZ linked an issue Apr 5, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #567 (f1a1d14) into main (59ab77e) will decrease coverage by 0.69%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   90.33%   89.64%   -0.69%     
==========================================
  Files          20       20              
  Lines        1304     1314      +10     
  Branches      475      481       +6     
==========================================
  Hits         1178     1178              
- Misses        125      135      +10     
  Partials        1        1              
Flag Coverage Δ
fulltest 87.74% <75.00%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/fields/meta/__init__.py 88.13% <75.00%> (-3.87%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit 0717a38 into main Apr 5, 2023
7 of 9 checks passed
@PythonFZ PythonFZ deleted the 566-eager-doesnt-work-with-zntrackmetatext branch April 5, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eager doesn't work with zntrack.meta.Text
1 participant