Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params loading #626

Merged
merged 4 commits into from
May 26, 2023
Merged

Params loading #626

merged 4 commits into from
May 26, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented May 26, 2023

You can do Node.from_rev() and access parameters.
If they are not present in params.yaml they will default to None instead of raising an exception.

  • Tests
  • raise correct exception

@PythonFZ PythonFZ added bug Something isn't working p1-important labels May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #626 (270d0b9) into main (a266604) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          20       20           
  Lines        1467     1467           
  Branches      569      569           
=======================================
  Hits         1307     1307           
  Misses        160      160           
Flag Coverage Δ
fulltest 89.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/fields/zn/__init__.py 90.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit 4dff358 into main May 26, 2023
12 checks passed
@PythonFZ PythonFZ deleted the params_loading branch May 26, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1-important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant