Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce build(nodes=list) #654

Merged
merged 1 commit into from
Jul 13, 2023
Merged

introduce build(nodes=list) #654

merged 1 commit into from
Jul 13, 2023

Conversation

PythonFZ
Copy link
Member

No description provided.

@PythonFZ PythonFZ linked an issue Jul 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #654 (a745c12) into main (8163bc0) will increase coverage by 0.16%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   89.74%   89.90%   +0.16%     
==========================================
  Files          21       21              
  Lines        1599     1625      +26     
  Branches      629      648      +19     
==========================================
+ Hits         1435     1461      +26     
  Misses        164      164              
Flag Coverage Δ
fulltest 89.90% <96.55%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/project/zntrack_project.py 90.61% <96.29%> (+0.56%) ⬆️
zntrack/core/load.py 100.00% <100.00%> (+2.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ merged commit 808ad39 into main Jul 13, 2023
12 checks passed
@PythonFZ PythonFZ deleted the 651-only-write-certain-nodes branch July 13, 2023 10:33
@Tetracarbonylnickel
Copy link

Wow that was fast :). I think that will really helpful.

Does project.build() then replace the former project.run(repro=False)?

>     project.build(nodes=[node_1, node_2])

>     project.repro()

In the example above one would use project.run(nodes=[node_1, node_2]) instead? Or is there not such a strict distinction here? Would be nice is build() replaces run(repro=False) because I think its a bit counterintuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only write certain nodes
2 participants