Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for external but not using external Node with params #655

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

PythonFZ
Copy link
Member

No description provided.

@PythonFZ PythonFZ linked an issue Jul 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #655 (7f7db97) into main (808ad39) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   89.90%   89.97%   +0.06%     
==========================================
  Files          21       21              
  Lines        1625     1626       +1     
  Branches      648      650       +2     
==========================================
+ Hits         1461     1463       +2     
+ Misses        164      163       -1     
Flag Coverage Δ
fulltest 89.97% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zntrack/utils/__init__.py 81.81% <ø> (+1.13%) ⬆️
zntrack/fields/zn/__init__.py 91.69% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ changed the title bugfix for externak but not using external Node with params bugfix for external but not using external Node with params Jul 13, 2023
@PythonFZ PythonFZ merged commit 8d1f776 into main Jul 13, 2023
11 checks passed
@PythonFZ PythonFZ deleted the 653-dvc-import-must-be-part-of-a-dummy-node branch July 13, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc import must be part of a dummy node
1 participant