Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #717

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Maintenance #717

merged 6 commits into from
Sep 18, 2023

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Sep 18, 2023

PR is noticeably slower compared to main (https://github.com/PythonFZ/ZnTrackPerformanceTest) but using a global variable for the files is a good addition.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #717 (c522fc8) into main (33ab97d) will decrease coverage by 0.31%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   90.11%   89.80%   -0.31%     
==========================================
  Files          22       22              
  Lines        1709     1697      -12     
  Branches      688      683       -5     
==========================================
- Hits         1540     1524      -16     
- Misses        169      173       +4     
Flag Coverage Δ
fulltest 89.80% <96.87%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
zntrack/fields/meta/__init__.py 88.88% <75.00%> (ø)
zntrack/core/node.py 93.51% <100.00%> (+0.53%) ⬆️
zntrack/core/nodify.py 95.30% <100.00%> (-0.04%) ⬇️
zntrack/fields/field.py 94.36% <100.00%> (ø)
zntrack/fields/zn/__init__.py 91.87% <100.00%> (ø)
zntrack/project/zntrack_project.py 91.25% <100.00%> (ø)
zntrack/utils/config.py 93.18% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PythonFZ PythonFZ marked this pull request as ready for review September 18, 2023 09:31
@PythonFZ PythonFZ merged commit 9ab4d52 into main Sep 18, 2023
10 of 12 checks passed
@PythonFZ PythonFZ deleted the maintenance branch September 18, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant