Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specify canonical url for articles #149

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Support specify canonical url for articles #149

merged 1 commit into from
Jan 27, 2023

Conversation

Folyd
Copy link
Member

@Folyd Folyd commented Jan 18, 2023

Resolve #141.

@Folyd Folyd marked this pull request as ready for review January 21, 2023 11:18
@Folyd Folyd requested a review from l1ch40 January 21, 2023 11:18
@Folyd
Copy link
Member Author

Folyd commented Jan 21, 2023

Cc. @Bas-Man

@Bas-Man
Copy link
Contributor

Bas-Man commented Jan 21, 2023

Away from pc for the next day or so. I will take a look once I am properly online.
Looking forward to see the results.

@Bas-Man
Copy link
Contributor

Bas-Man commented Jan 23, 2023

The code look good. But I am getting an error when I try to create a new zine with this branch

listening on http://127.0.0.1:3000
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Template 'author.jinja' not found', /Users/redacted/Documents/Development/rust/zine/src/build.rs:72:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Folyd
Copy link
Member Author

Folyd commented Jan 26, 2023

The code look good. But I am getting an error when I try to create a new zine with this branch

listening on http://127.0.0.1:3000
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Template 'author.jinja' not found', /Users/redacted/Documents/Development/rust/zine/src/build.rs:72:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sorry, I can't reproduce this.

@Folyd Folyd merged commit fba44ba into master Jan 27, 2023
@Folyd Folyd deleted the canonical branch January 27, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "canonical" link in header with support for specifying alternate for articles.
2 participants