fix date format panic #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for this unwrap to panic. Replaced with a match to hand the success and fail case. The Err() may still be improved.
This Err() still needs to be handled more correctly. I think.
Closed
Folyd
reviewed
Feb 9, 2023
|
It breaks from the standard. It could be done. But I don’t think it’s the right option. Probably have the string reformatted. Then have that written back to to the article struct. Then you need to overwrite the zine.toml so that it stays fixed. This issue would only happen if someone manually adjusted the date. If the server handles it. It teaches the users not to follow the standard. I think it would be best to let the error occur so the author fixes it and learns the correct format. On Feb 9, 2023, at 11:24, Folyd ***@***.***> wrote:
@Folyd commented on this pull request.
Can we also support formats like "2023-1-31" or "2023-1-1", it is better than simply printing errors. What do you think?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Yes, fair enough. 👍 |
|
In addition. If it was ever decided to add time. There would be more issues and breakages. |
|
Don't forget to run |
|
Sorry. I will try to get into the habit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code will still panic in
debugmode. It will close cleanly in production███████╗██╗███╗ ██╗███████╗ ╚══███╔╝██║████╗ ██║██╔════╝ ███╔╝ ██║██╔██╗ ██║█████╗ ███╔╝ ██║██║╚██╗██║██╔══╝ ███████╗██║██║ ╚████║███████╗ ╚══════╝╚═╝╚═╝ ╚═══╝╚══════╝ listening on http://127.0.0.1:3000 Error: The date value 2023-1-31 is invalid: the 'month' component could not be parsed for key `article` at line 6 column 1This should close #164