Add version command to show version info #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folyd
requested changes
Aug 15, 2022
build.rs
Outdated
| println!("cargo:rustc-env=GIT_BRANCH={}", branch); | ||
|
|
||
| // Read date from current build branch. | ||
| let date_binding = run(&["git", "show", &branch, "--pretty=format:\"%ci %cr\""]).unwrap(); |
There was a problem hiding this comment.
Giving a brief output comment is a good practice to help others grasp the code quickly.
Such as:
// Here is an example output:
//
// 2022-08-06 18:39:39 +02009 days ago
// ...
let date_binding = run(&["git", "show", &branch, "--pretty=format:\"%ci %cr\""]).unwrap();
|
Thanks for guiding! I have tried to improve them! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it can show the Cargo pkg version and the last commit id with date and branch. #75