Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl schema definition instead of json for csv schema #473

Closed
sonalgoyal opened this issue Dec 15, 2022 · 2 comments
Closed

ddl schema definition instead of json for csv schema #473

sonalgoyal opened this issue Dec 15, 2022 · 2 comments
Assignees
@sonalgoyal @vikasgupta78
Milestone
0.3.5

Comments

@sonalgoyal
Copy link
Member

current way of defining schema for csv is very cumbersome. instead, we should support ddl like "fname string, lname string.."
@sonalgoyal sonalgoyal self-assigned this Dec 15, 2022
@sonalgoyal sonalgoyal added this to the 0.3.5 milestone Mar 20, 2023
@vikasgupta78 vikasgupta78 mentioned this issue Mar 31, 2023
Merged
sonalgoyal added a commit that referenced this issue Mar 31, 2023
@sonalgoyal
Merge pull request #557 from zinggAI/cleanupmethod
dd0ab0e 
ddl schema definition instead of json for csv schema #473
@vikasgupta78
Copy link
Collaborator

pull request #557

@vikasgupta78
Copy link
Collaborator

all models now regenerated and schema fixed both in config json and python

pull request #559

sonalgoyal added a commit that referenced this issue Apr 1, 2023
@sonalgoyal
Merge pull request #559 from zinggAI/0.3.5
75970fb 
issue #473 and #285
@vikasgupta78 vikasgupta78 mentioned this issue Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonalgoyal sonalgoyal

@vikasgupta78 vikasgupta78

Labels
None yet
Projects
None yet
Milestone
0.3.5
Development

No branches or pull requests
2 participants
@sonalgoyal @vikasgupta78