Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrainingDataFinder needs to create label model #635

Closed
vikasgupta78 opened this issue Aug 8, 2023 · 0 comments
Closed

TrainingDataFinder needs to create label model #635

vikasgupta78 opened this issue Aug 8, 2023 · 0 comments

Comments

@vikasgupta78
Copy link
Collaborator

Model<S,T,D,R,C> model = getModelUtil().createModel(posPairs, negPairs, false, args);

should be

Model<S,T,D,R,C> model = getModelUtil().createModel(posPairs, negPairs, true, args);
vikasgupta78 added a commit to zinggAI/zingg-vikas that referenced this issue Aug 8, 2023
@vikasgupta78
ftd phase should create different model class zinggAI#635
953fd55
@vikasgupta78 vikasgupta78 mentioned this issue Aug 8, 2023
Merged
sonalgoyal added a commit that referenced this issue Aug 8, 2023
@sonalgoyal
Merge pull request #637 from zinggAI/issue635
b0f937b 
ftd phase should create different model class #635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vikasgupta78