Blocking tree are saved in parquet file #82 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgoyal
reviewed
Jan 10, 2022
| @@ -469,7 +471,18 @@ public static String getCurrentLabelPath(String path) throws IOException { | |||
| return dupesActual; | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
should there be some kind of buffering? bufferedoutputstream etc?
There was a problem hiding this comment.
There should not be any buffering, I feel. Buffering happens mainly for relatively expensive operations like disk I/O, network activity. Also, particular operation should be quite often.
Your opinion please?
There was a problem hiding this comment.
buffering is pretty standard, dont see how it harms. please add.
There was a problem hiding this comment.
Yes. Added. Hope it is the correct way and does the expected.
| List<Object> objList = new ArrayList<>(); | ||
| objList.add(byteArray); | ||
| JavaRDD<Row> rowRDD = ctx.parallelize(objList).map((Object row) -> RowFactory.create(row)); | ||
| Dataset<Row> df = spark.sqlContext().createDataFrame(rowRDD, schema).toDF(); |
There was a problem hiding this comment.
shouldnt we coalesce the df before writing?
sonalgoyal
requested changes
Jan 10, 2022
navinrathore
force-pushed
the
zBlockingTree
branch
from
b513ed9
to
d70ef74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"zingg.block" is a directory comprising parquet files. It was a file.
BlockingtreePipe, by default, has Overwrite mode. It should be OK in read().